Issue 7105054: state: add SetPassword, IsValid

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by rog

Modified:
11 years, 3 months ago

Reviewers:
mp+143162

Visibility:
Public.

Description

state: add SetPassword, IsValid These methods access the passwords that the API will use to determine access. https://code.launchpad.net/~rogpeppe/juju-core/190-state-api-passwords/+merge/143162 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state: add SetPassword, IsValid #

Patch Set 3 : state: add SetPassword, IsValid #

Total comments: 3

Patch Set 4 : state: add SetPassword, IsValid #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+101 lines, -7 lines)			Patch
A	[revision details]	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/machine.go	View	1	2 chunks	+30 lines, -7 lines	0 comments	Download
M	state/machine_test.go	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	state/state_test.go	View	1	1 chunk	+33 lines, -0 lines	0 comments	Download
M	state/unit.go	View	1	2 chunks	+24 lines, -0 lines	0 comments	Download
M	state/unit_test.go	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dimitern

LGTM with one suggestion. https://codereview.appspot.com/7105054/diff/1023/state/machine.go File state/machine.go (right): https://codereview.appspot.com/7105054/diff/1023/state/machine.go#newcode118 state/machine.go:118: // SetPassword sets the password ...

11 years, 3 months ago (2013-01-15 09:45:05 UTC) #2

rog

https://codereview.appspot.com/7105054/diff/1023/state/machine.go File state/machine.go (right): https://codereview.appspot.com/7105054/diff/1023/state/machine.go#newcode118 state/machine.go:118: // SetPassword sets the password for the machine's agent. ...

11 years, 3 months ago (2013-01-15 10:28:48 UTC) #3

fwereade

LGTM https://codereview.appspot.com/7105054/diff/1023/state/machine.go File state/machine.go (right): https://codereview.appspot.com/7105054/diff/1023/state/machine.go#newcode118 state/machine.go:118: // SetPassword sets the password for the machine's ...

11 years, 3 months ago (2013-01-15 10:45:24 UTC) #4

rog

11 years, 3 months ago (2013-01-15 10:59:05 UTC) #5

*** Submitted:

state: add SetPassword, IsValid

These methods access the passwords that the API will
use to determine access.

R=dimitern, fwereade
CC=
https://codereview.appspot.com/7105054

Expand All Messages | Collapse All Messages