Issue 7103060: code review 7103060: goprotobuf: Rename UnmarshalAppend to UnmarshalMerge.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7103060: code review 7103060: goprotobuf: Rename UnmarshalAppend to UnmarshalMerge. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by dsymonds

Modified:
12 years, 10 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

goprotobuf: Rename UnmarshalAppend to UnmarshalMerge. "Merge" is the term used in C++ (and other languages), and "append" doesn't correctly capture the semantics for non-repeated fields.

Patch Set 1 #

Patch Set 2 : diff -r c9572f75eef0 https://code.google.com/p/goprotobuf #

Patch Set 3 : diff -r c9572f75eef0 https://code.google.com/p/goprotobuf #

Patch Set 4 : diff -r c9572f75eef0 https://code.google.com/p/goprotobuf #

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -11 lines)			Patch
	M	proto/all_test.go	View	1	2 chunks	+6 lines, -6 lines	0 comments	Download
	M	proto/decode.go	View	1	1 chunk	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dsymonds

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/goprotobuf

12 years, 10 months ago (2013-01-15 01:52:28 UTC) #1

dsymonds

12 years, 10 months ago (2013-01-15 03:30:32 UTC) #3

*** Submitted as
https://code.google.com/p/goprotobuf/source/detail?r=31e1306dcf36 ***

goprotobuf: Rename UnmarshalAppend to UnmarshalMerge.

"Merge" is the term used in C++ (and other languages),
and "append" doesn't correctly capture the semantics for non-repeated fields.

R=rsc
CC=golang-dev
https://codereview.appspot.com/7103060

Expand All Messages | Collapse All Messages