Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(101)

Issue 7103058: code review 7103058: go/types: typechecking conversions, part 1 (non-constants) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 5 months ago by gri
Modified:
12 years, 5 months ago
Reviewers:
CC:
adonovan, golang-dev
Visibility:
Public.

Description

go/types: typechecking conversions, part 1 (non-constants)

Patch Set 1 #

Patch Set 2 : diff -r 09fb356c09cc https://code.google.com/p/go #

Patch Set 3 : diff -r ef1ce4503d85 https://code.google.com/p/go #

Patch Set 4 : diff -r ef1ce4503d85 https://code.google.com/p/go #

Patch Set 5 : diff -r 8516cee2bf33 https://code.google.com/p/go #

Patch Set 6 : diff -r 8516cee2bf33 https://code.google.com/p/go #

Patch Set 7 : diff -r d8bddc63dacc https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -2 lines) Patch
M src/pkg/go/types/conversions.go View 1 2 3 4 2 chunks +89 lines, -2 lines 0 comments Download

Messages

Total messages: 3
gri
Hello adonovan@google.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
12 years, 5 months ago (2013-01-19 00:35:47 UTC) #1
adonovan
LGTM. (Sorry for the delay; my filter is a bit aggressive about keeping things out ...
12 years, 5 months ago (2013-01-22 19:47:35 UTC) #2
gri
12 years, 5 months ago (2013-01-23 19:06:06 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=45a405b5c63a ***

go/types: typechecking conversions, part 1 (non-constants)

R=adonovan
CC=golang-dev
https://codereview.appspot.com/7103058
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b