Issue 7102055: Test fix for mousemove.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7102055: Test fix for mousemove.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by matthew.scott

Modified:
11 years, 3 months ago

Reviewers:
mp+143133

Visibility:
Public.

Description

Test fix for mousemove. Mousemove test was failing due to simulated mousemove events not providing a new X/Y coordinate. This caused intermittent failures depending on where the mouse was when tests were started. Fixed by providing coords to ensure the handler is fired. Proposing as I'd like to make sure this works for others. https://code.launchpad.net/~makyo/juju-gui/mousemove-simulate/+merge/143133 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Test fix for mousemove. #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	A	[revision details]	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	test/test_environment_view.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

brad.crittenden

This patch looks good and fixes the problem I was just whining about. Land as ...

11 years, 3 months ago (2013-01-14 19:29:12 UTC) #3

matthew.scott

11 years, 3 months ago (2013-01-14 19:34:25 UTC) #4

*** Submitted:

Test fix for mousemove.

Mousemove test was failing due to simulated mousemove events not providing a new
X/Y coordinate.  This caused intermittent failures depending on where the mouse
was when tests were started.  Fixed by providing coords to ensure the handler is
fired.  Proposing as I'd like to make sure this works for others.

R=frankban, brad.crittenden
CC=
https://codereview.appspot.com/7102055

Expand All Messages | Collapse All Messages