Issue 7101046: code review 7101046: time: add note about Parse()'s choice of default year

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7101046: code review 7101046: time: add note about Parse()'s choice of default year (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by minux1

Modified:
12 years, 11 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

time: add note about Parse()'s choice of default year

Patch Set 2 : diff -r 760f1daa6700 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 760f1daa6700 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 4 : diff -r 1b57fb106d8d https://code.google.com/p/go/ #

Patch Set 5 : diff -r 1b57fb106d8d https://code.google.com/p/go/ #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/pkg/time/format.go	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

minux1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years, 11 months ago (2013-01-13 21:56:56 UTC) #1

minux1

relevant discussion on golang-nuts: https://groups.google.com/forum/#!topic/golang-nuts/4dZBxQQ2Plk

12 years, 11 months ago (2013-01-13 21:58:50 UTC) #2

rsc

LGTM No "time." in package time's docs. https://codereview.appspot.com/7101046/diff/6001/src/pkg/time/format.go File src/pkg/time/format.go (right): https://codereview.appspot.com/7101046/diff/6001/src/pkg/time/format.go#newcode640 src/pkg/time/format.go:640: // corresponding ...

12 years, 11 months ago (2013-01-18 20:45:45 UTC) #3

minux1

12 years, 11 months ago (2013-01-18 20:57:43 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=6519eef2c815 ***

time: add note about Parse()'s choice of default year

R=rsc
CC=golang-dev
https://codereview.appspot.com/7101046

Expand All Messages | Collapse All Messages