Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(771)

Issue 7100050: code review 7100050: net: introduce noncgo_net build tag to disable cgo only... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 10 months ago by minux1
Modified:
4 years, 5 months ago
Reviewers:
rsc, iant
CC:
golang-dev, bradfitz, rsc, iant
Visibility:
Public.

Description

net: introduce netgo build tag to build a pure Go net package. Fixes issue 4078.

Patch Set 1 #

Patch Set 2 : diff -r a447f188d3d8 https://code.google.com/p/go #

Patch Set 3 : diff -r 4aa7943034c5 https://code.google.com/p/go #

Patch Set 4 : diff -r 9b1143bb425e https://code.google.com/p/go/ #

Patch Set 5 : diff -r 3361afb4f8de https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M doc/go1.2.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/net/cgo_bsd.go View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/net/cgo_linux.go View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M src/pkg/net/cgo_netbsd.go View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M src/pkg/net/cgo_openbsd.go View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M src/pkg/net/cgo_stub.go View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/net/cgo_unix.go View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12
bradfitz
R=rsc ... since he filed Issue 4078.
4 years, 5 months ago (2013-06-04 21:58:36 UTC) #1
minux1
Hello golang-dev@googlegroups.com, bradfitz@golang.org, rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
4 years, 5 months ago (2013-06-07 09:36:37 UTC) #2
iant
I don't understand what will set this build tag. Negated names are always hard to ...
4 years, 5 months ago (2013-06-07 13:36:22 UTC) #3
minux1
On 2013/06/07 13:36:22, iant wrote: > I don't understand what will set this build tag. ...
4 years, 5 months ago (2013-06-07 14:00:50 UTC) #4
iant
On 2013/06/07 14:00:50, minux wrote: > yeah, i like cgonet better, but we need to ...
4 years, 5 months ago (2013-06-07 14:30:52 UTC) #5
rsc
The negative is precisely because we can't introduce a new tag that's always on. We ...
4 years, 5 months ago (2013-06-10 17:48:55 UTC) #6
minux1
PTAL, changed to use netgo, and updated doc/go1.2.txt. On 2013/06/10 17:48:55, rsc wrote: > Using ...
4 years, 5 months ago (2013-06-10 17:55:33 UTC) #7
iant
Update the CL description.
4 years, 5 months ago (2013-06-10 18:06:41 UTC) #8
minux1
On 2013/06/10 18:06:41, iant wrote: > Update the CL description. thank you, done.
4 years, 5 months ago (2013-06-10 18:11:38 UTC) #9
iant
LGTM Wait for rsc.
4 years, 5 months ago (2013-06-10 18:13:06 UTC) #10
rsc
LGTM
4 years, 5 months ago (2013-06-10 18:51:16 UTC) #11
minux1
4 years, 5 months ago (2013-06-10 18:55:25 UTC) #12
*** Submitted as https://code.google.com/p/go/source/detail?r=17822bec6f33 ***

net: introduce netgo build tag to build a pure Go net package.
Fixes issue 4078.

R=golang-dev, bradfitz, rsc, iant
CC=golang-dev
https://codereview.appspot.com/7100050
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld c59f3c4