Issue 7098053: all: rename SetPassword to SetMongoPassword

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7098053: all: rename SetPassword to SetMongoPassword

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by rog

Modified:
11 years, 3 months ago

Reviewers:
mp+143137

Visibility:
Public.

Description

all: rename SetPassword to SetMongoPassword The CL will add SetPassword methods for the API. Eventually, we'll deprecate all but Machine.SetMongoPassword (and perhaps State.SetAdminMongoPassword). https://code.launchpad.net/~rogpeppe/juju-core/191-rename-setpassword/+merge/143137 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : all: rename SetPassword to SetMongoPassword #

Patch Set 3 : all: rename SetPassword to SetMongoPassword #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -53 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/jujud/agent.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	cmd/jujud/agent_test.go	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	cmd/jujud/bootstrap.go	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	cmd/jujud/bootstrap_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	cmd/jujud/machine_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	cmd/jujud/unit_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	cmd/jujud/upgrade.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	cmd/jujud/upgrade_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	environs/dummy/environs.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	juju/conn.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	juju/conn_test.go	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	juju/testing/conn.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	state/machine.go	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	state/machine_test.go	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	state/state.go	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	state/state_test.go	View	5 chunks	+14 lines, -14 lines	0 comments	Download
M	state/unit.go	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	state/unit_test.go	View	5 chunks	+8 lines, -8 lines	0 comments	Download
M	worker/deployer/deployer.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	worker/provisioner/provisioner.go	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

TheMue

Technically LGTM, but normally I'm no friend of a product name in the API (like ...

11 years, 3 months ago (2013-01-14 16:14:18 UTC) #2

rog

11 years, 3 months ago (2013-01-14 18:29:20 UTC) #4

*** Submitted:

all: rename SetPassword to SetMongoPassword

The CL will add SetPassword methods for the API.
Eventually, we'll deprecate all but Machine.SetMongoPassword
(and perhaps State.SetAdminMongoPassword).

R=TheMue, fwereade
CC=
https://codereview.appspot.com/7098053

Expand All Messages | Collapse All Messages