code review 7096048: go/types: Moving from *ast.Objects to types.Objects (st...

go/types: Moving from *ast.Objects to types.Objects (step 2).

Completely removed *ast.Objects from being exposed by the
types API. *ast.Objects are still required internally for
resolution, but now the door is open for an internal-only
rewrite of identifier resolution entirely at type-check
time. Once that is done, ASTs can be type-checked whether
they have been created via the go/parser or otherwise,
and type-checking does not require *ast.Object or scope
invariants to be maintained externally.

[gri, 2013-01-13 00:42:21]

Hello adonovan@google.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[adonovan, 2013-01-13 03:16:18]

LGTM

API changes look good (but there goes my Monday).

The code changes seem reasonable but I haven't had time to look carefully at
them; given your time constraints, the need to keep parallel efforts unblocked,
and your out-of-band pleas to avoid sweating the small stuff, I'm LGTMing this
now, but if you want more detailed review let me know and I'll look as soon as I
can, likely Monday.

[gri, 2013-01-13 18:33:34]

*** Submitted as https://code.google.com/p/go/source/detail?r=760f1daa6700 ***

go/types: Moving from *ast.Objects to types.Objects (step 2).

Completely removed *ast.Objects from being exposed by the
types API. *ast.Objects are still required internally for
resolution, but now the door is open for an internal-only
rewrite of identifier resolution entirely at type-check
time. Once that is done, ASTs can be type-checked whether
they have been created via the go/parser or otherwise,
and type-checking does not require *ast.Object or scope
invariants to be maintained externally.

R=adonovan
CC=golang-dev
https://codereview.appspot.com/7096048