Issue 7095054: code review 7095054: re2: misc cleanup

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7095054: code review 7095054: re2: misc cleanup (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by rsc

Modified:
12 years, 8 months ago

Reviewers:

CC:
rsc, re2-dev_googlegroups.com

Visibility:
Public.

Description

re2: misc cleanup - use int64 for size computation in dfa.cc - add copyright notice to testinstall.cc - defer to predefined ANNOTATE_* macros in util.h - remove x bit from unicode.py

Patch Set 1 #

Patch Set 2 : diff -r dd841cbcdafa https://code.google.com/p/re2/ #

Patch Set 3 : diff -r dd841cbcdafa https://code.google.com/p/re2/ #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
M	re2/dfa.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	re2/unicode.py	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	testinstall.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	util/util.h	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

Hello rsc (cc: re2-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/re2/

12 years, 8 months ago (2013-01-14 18:37:38 UTC) #1

rsc

12 years, 8 months ago (2013-01-14 18:37:44 UTC) #2

*** Submitted as https://code.google.com/p/re2/source/detail?r=ed5c8697586b ***

re2: misc cleanup

- use int64 for size computation in dfa.cc
- add copyright notice to testinstall.cc
- defer to predefined ANNOTATE_* macros in util.h
- remove x bit from unicode.py

R=rsc
CC=re2-dev
https://codereview.appspot.com/7095054

Expand All Messages | Collapse All Messages