Issue 7094052: doc/draft: entity destruction docs

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7094052: doc/draft: entity destruction docs

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by fwereade

Modified:
11 years, 3 months ago

Reviewers:
mp+143034, rog, dimitern, TheMue

Visibility:
Public.

Description

doc/draft: entity destruction docs https://code.launchpad.net/~fwereade/juju-core/death-and-destruction/+merge/143034 (do not edit description out of merge proposal)

Patch Set 2 : doc/draft: entity destruction docs #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+204 lines, -0 lines)			Patch
	A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
	A	doc/draft/death-and-destruction.txt	View	1	1 chunk	+202 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

fwereade

Oversight https://codereview.appspot.com/7094052/diff/1/doc/draft/death-and-destruction.txt File doc/draft/death-and-destruction.txt (right): https://codereview.appspot.com/7094052/diff/1/doc/draft/death-and-destruction.txt#newcode97 doc/draft/death-and-destruction.txt:97: when the unit is Alive). * The unit's ...

11 years, 3 months ago (2013-01-14 08:57:44 UTC) #2

fwereade

*** Submitted: doc/draft: entity destruction docs R=TheMue, dimitern CC= https://codereview.appspot.com/7094052

11 years, 3 months ago (2013-01-14 21:33:29 UTC) #5

rog

11 years, 3 months ago (2013-01-15 08:31:28 UTC) #6

a couple of comments i didn't publish.
LGTM in general, although as i said on-line,
i think this would probably work better
as a comment in the state package, as it's
essentially internal documentation for that package.

https://codereview.appspot.com/7094052/diff/1/doc/draft/death-and-destruction...
File doc/draft/death-and-destruction.txt (right):

https://codereview.appspot.com/7094052/diff/1/doc/draft/death-and-destruction...
doc/draft/death-and-destruction.txt:4: This document describes in detail the
operations associated with the destruction
s/in detail// (unnecessary)

https://codereview.appspot.com/7094052/diff/1/doc/draft/death-and-destruction...
doc/draft/death-and-destruction.txt:5: and removal of the fundamental state
entities, and what agents are responsible
might be nice to say here in the summary what those state entities are
e.g.
s/entities/entities (machines, units, relations and services)/

Expand All Messages | Collapse All Messages