code review 70940043: runtime: update CBARGS macro for nacl/amd64p32

runtime: update CBARGS macro for nacl/amd64p32

CBARGS is unused on amd64p32 so make this explicit.

[dave_cheney.net, 2014-03-03 22:54:20]

Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2014-03-03 22:55:38]

LGTM

(matches Russ' previous request)



On Mon, Mar 3, 2014 at 2:54 PM, <dave@cheney.net> wrote:

> Reviewers: rsc,
>
> Message:
> Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> runtime: update CBARGS macro for nacl/amd64p32
>
> CBARGS is unused on amd64p32 so make this explicit.
>
> Please review this at https://codereview.appspot.com/70940043/
>
> Affected files (+2, -3 lines):
>   M src/pkg/runtime/cgocall.c
>
>
> Index: src/pkg/runtime/cgocall.c
> ===================================================================
> --- a/src/pkg/runtime/cgocall.c
> +++ b/src/pkg/runtime/cgocall.c
> @@ -223,10 +223,9 @@
>  #define CBARGS (CallbackArgs*)((byte*)m->g0->sched.sp+2*sizeof(void*))
>  #endif
>
> -// There is no cgo support for nacl/amd64p32 but we need to have
> something here
> -// so use the amd64 value as a placeholder.
> +// Unimplemented on amd64p32
>  #ifdef GOARCH_amd64p32
> -#define CBARGS (CallbackArgs*)((byte*)m->g0->sched.sp+2*sizeof(void*))
> +#define CBARGS (CallbackArgs*)(nil)
>  #endif
>
>  // On 386, stack frame is three words, plus caller PC.
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>

[dave_cheney.net, 2014-03-03 23:36:17]

*** Submitted as https://code.google.com/p/go/source/detail?r=d99a2e24dd10 ***

runtime: update CBARGS macro for nacl/amd64p32

CBARGS is unused on amd64p32 so make this explicit.

LGTM=bradfitz
R=rsc, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/70940043

[gobot, 2014-03-03 23:39:57]

This CL appears to have broken the dragonfly-386 builder.