Issue 7093060: Revno can be configured

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7093060: Revno can be configured

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by abentley-home

Modified:
11 years, 3 months ago

Reviewers:
hazmat, mp+143175, aaron

Visibility:
Public.

Description

Revno can be configured With this change, revno is a configurable value. If a non-negative value is specified, the source is updated to that value. -1 is treated as branch tip, and does not trigger updates. It is the default. Other negative values are forbidden. https://code.launchpad.net/~abentley/charms/precise/charmworld/revno-config/+merge/143175 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -4 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	config.yaml	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	hooks/config-changed	View	4 chunks	+17 lines, -3 lines	1 comment	Download
M	revision	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

hazmat

looks good, go ahead and merge. https://codereview.appspot.com/7093060/diff/1/hooks/config-changed File hooks/config-changed (right): https://codereview.appspot.com/7093060/diff/1/hooks/config-changed#newcode41 hooks/config-changed:41: update_source its debatable ...

11 years, 3 months ago (2013-01-14 19:56:48 UTC) #2

aaron_aaronbentley.com

11 years, 3 months ago (2013-01-14 20:01:57 UTC) #3

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 13-01-14 02:56 PM, kapilt@gmail.com wrote:
> https://codereview.appspot.com/7093060/diff/1/hooks/config-changed#newcode41
>
>  hooks/config-changed:41: update_source its debatable if it should,
> but should revno -1 opportunistically update?

If it did, -1 would mean we'd update the source code whenever
configuration changed, and I think that would be unexpected.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with undefined - http://www.enigmail.net/

iEYEARECAAYFAlD0ZDMACgkQ0F+nu1YWqI37zQCfZyBx9TzDHQ5bhEQGbcFK8IU1
FGUAnA+ln4RhcGyjBW9bmnVDuAk/6ysu
=fjk0
-----END PGP SIGNATURE-----

Expand All Messages | Collapse All Messages