Issue 7093053: code review 7093053: taowm: unbreak doWorkspaceNew; it created two workspace...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7093053: code review 7093053: taowm: unbreak doWorkspaceNew; it created two workspace... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by nigeltao

Modified:
13 years ago

Reviewers:

CC:
nigeltao, taowm_googlegroups.com

Visibility:
Public.

Description

taowm: unbreak doWorkspaceNew; it created two workspaces for the same screen. Refactor clickX to use changeX, for X in {Window,Workspace}. Fix workspace.frameContaining to consider fullscreen-ness.

Patch Set 1 #

Patch Set 2 : diff -r 2e96e69f3b42 https://code.google.com/p/taowm/ #

Patch Set 3 : diff -r 2e96e69f3b42 https://code.google.com/p/taowm/ #

Patch Set 4 : diff -r 2e96e69f3b42 https://code.google.com/p/taowm/ #

Created: 13 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -74 lines)			Patch
M	taowm/actions.go	View	1	3 chunks	+19 lines, -14 lines	0 comments	Download
M	taowm/geom.go	View	1	3 chunks	+11 lines, -15 lines	0 comments	Download
M	taowm/input.go	View	1	3 chunks	+4 lines, -44 lines	0 comments	Download
M	taowm/xinit.go	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

nigeltao

Hello nigeltao@golang.org (cc: taowm@googlegroups.com), I'd like you to review this change to https://code.google.com/p/taowm/

13 years ago (2013-01-13 11:16:20 UTC) #1

nigeltao

13 years ago (2013-01-13 11:17:12 UTC) #2

*** Submitted as https://code.google.com/p/taowm/source/detail?r=d745f583433a
***

taowm: unbreak doWorkspaceNew; it created two workspaces for the same
screen. Refactor clickX to use changeX, for X in {Window,Workspace}.
Fix workspace.frameContaining to consider fullscreen-ness.

R=nigeltao
CC=taowm
https://codereview.appspot.com/7093053

Expand All Messages | Collapse All Messages