Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(27)

Issue 7092055: Environments have uuids (regression fix for subs)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by hazmat
Modified:
9 years, 6 months ago
Reviewers:
bcsaller, mp+143188, jimbaker
Visibility:
Public.

Description

Environments have uuids (regression fix for subs) Previous environment uuid work caused issues with subordinates, added an additional test and one line fix for. Fixes bugs https://bugs.launchpad.net/juju/+bug/1100245 https://bugs.launchpad.net/juju/+bug/1100348 https://code.launchpad.net/~hazmat/juju/env-id/+merge/143188 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Environments have uuids. #

Patch Set 3 : Environments have uuids. #

Patch Set 4 : Environments have uuids (regression fix for subs) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M juju/unit/deploy.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M juju/unit/tests/test_deploy.py View 1 2 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7
hazmat
Please take a look.
9 years, 6 months ago (2013-01-14 21:55:41 UTC) #1
bcsaller
LGTM. It will be worth adding a note to the hook docs that this env ...
9 years, 6 months ago (2013-01-15 14:42:47 UTC) #2
hazmat
On 2013/01/15 14:42:47, bcsaller wrote: > LGTM. It will be worth adding a note to ...
9 years, 6 months ago (2013-01-15 15:30:57 UTC) #3
hazmat
*** Submitted: Environments have uuids. Data collection tools that want to operate on multiple environments ...
9 years, 6 months ago (2013-01-15 21:24:20 UTC) #4
hazmat
Please take a look.
9 years, 6 months ago (2013-01-16 19:02:23 UTC) #5
jimbaker
On 2013/01/16 19:02:23, hazmat wrote: > Please take a look. +1, LGTM
9 years, 6 months ago (2013-01-16 19:20:22 UTC) #6
hazmat
9 years, 6 months ago (2013-01-16 19:26:52 UTC) #7
*** Submitted:

Environments have uuids (regression fix for subs)

Previous environment uuid work caused issues with subordinates, added
an additional test and one line fix for. Fixes bugs

https://bugs.launchpad.net/juju/+bug/1100245
https://bugs.launchpad.net/juju/+bug/1100348

R=jimbaker
CC=
https://codereview.appspot.com/7092055
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b