Issue 7092048: http issue 143: HttpResponseException should have getContent() method

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7092048: http issue 143: HttpResponseException should have getContent() method (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by yanivi

Modified:
11 years, 3 months ago

Reviewers:
ngmiceli

CC:
rmistry

Base URL:
https://code.google.com/p/google-http-java-client/

Visibility:
Public.

More Reviews

Description

http issue 143: HttpResponseException should have getContent() method http://code.google.com/p/google-http-java-client/issues/detail?id=143

Patch Set 3 : new constructor HttpResponseException.Builder(int statusCode, String statusMesssage, HttpHeaders) #

Patch Set 4 : fix javadoc comments #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+212 lines, -14 lines)			Patch
	M	google-http-client/src/main/java/com/google/api/client/http/HttpResponseException.java	View	1 2 3	5 chunks	+187 lines, -13 lines	0 comments	Download
	M	google-http-client/src/test/java/com/google/api/client/http/HttpResponseExceptionTest.java	View	1 2	4 chunks	+25 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

ngmiceli

https://codereview.appspot.com/7092048/diff/3001/google-http-client/src/main/java/com/google/api/client/http/HttpResponseException.java File google-http-client/src/main/java/com/google/api/client/http/HttpResponseException.java (right): https://codereview.appspot.com/7092048/diff/3001/google-http-client/src/main/java/com/google/api/client/http/HttpResponseException.java#newcode26 google-http-client/src/main/java/com/google/api/client/http/HttpResponseException.java:26: * Implementations is not thread safe. Implementation is (singular) ...

11 years, 3 months ago (2013-01-14 16:02:38 UTC) #2

yanivi

see also Patch Set 3 : new constructor HttpResponseException.Builder(int statusCode, String statusMesssage, HttpHeaders) https://codereview.appspot.com/7092048/diff/3001/google-http-client/src/main/java/com/google/api/client/http/HttpResponseException.java File ...

11 years, 3 months ago (2013-01-14 16:43:40 UTC) #3

LGTM

Expand All Messages | Collapse All Messages