Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2155)

Issue 7090043: code review 7090043: cmd/5c: fix handling of side effects when assigning a s... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by remyoudompheng
Modified:
9 years, 10 months ago
Reviewers:
CC:
rsc, golang-dev, dfc, minux1, lucio, bradfitz
Visibility:
Public.

Description

cmd/5c: fix handling of side effects when assigning a struct literal. Also undo revision a5b96b602690 used to workaround the bug. Fixes issue 4643.

Patch Set 1 #

Patch Set 2 : diff -r e8cfa948baf2 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r e8cfa948baf2 https://code.google.com/p/go #

Patch Set 4 : diff -r 182a8878488b https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M src/cmd/5c/cgen.c View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/runtime/mgc0.c View 1 2 4 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 7
remyoudompheng
Hello rsc@golang.org, golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
9 years, 10 months ago (2013-01-11 07:12:10 UTC) #1
dfc
Here is the asm afterwards *bitbufpos++ = (BitTarget){obj, ti, bitp, shift}; 59180: e59d0020 ldr r0, ...
9 years, 10 months ago (2013-01-11 22:19:32 UTC) #2
minux1
LGTM. The bug doesn't exist in cmd/6c and cmd/8c since their inclusion (although the comment ...
9 years, 10 months ago (2013-01-12 07:24:32 UTC) #3
lucio
I'm going to shoot from the hip here, so don't be shy to correct me. ...
9 years, 10 months ago (2013-01-12 07:34:57 UTC) #4
minux1
On Sat, Jan 12, 2013 at 3:34 PM, Lucio De Re <lucio.dere@gmail.com> wrote: > I'm ...
9 years, 10 months ago (2013-01-12 07:42:39 UTC) #5
bradfitz
Richard, see https://code.google.com/p/go/issues/detail?id=4643 On Fri, Jan 11, 2013 at 11:34 PM, Lucio De Re <lucio.dere@gmail.com> ...
9 years, 10 months ago (2013-01-12 07:43:25 UTC) #6
remyoudompheng
9 years, 10 months ago (2013-01-12 08:17:23 UTC) #7
*** Submitted as https://code.google.com/p/go/source/detail?r=ecab7a7e7c7e ***

cmd/5c: fix handling of side effects when assigning a struct literal.

Also undo revision a5b96b602690 used to workaround the bug.

Fixes issue 4643.

R=rsc, golang-dev, dave, minux.ma, lucio.dere, bradfitz
CC=golang-dev
https://codereview.appspot.com/7090043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b