code review 7085056: database/sql: Add an optional Queryer-Interface (like E...

database/sql: Add an optional Queryer-Interface (like Execer)

Completly the same like the Execer-Interface, just for Queries.
This allows Drivers to execute Queries without preparing them first

[julienschmidt, 2013-01-14 01:53:30]

All test pass with $GOROOT/src/all.bash. Also tested with
https://github.com/bradfitz/go-sql-test and my reference implementation of the
Queryer-Interface (Should it be named Querier?) for my MySQL-Driver:
https://github.com/JulienSchmidt/Go-MySQL-Driver/commit/60ced5014af9b63a725fe...

[julienschmidt, 2013-01-14 02:00:23]

Hello golang-dev@googlegroups.com (cc: bradfitz@golang.org),

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2013-01-19 17:03:13]

Sorry for the slow review... I was backlogged.

This looks nice.  I thought there was a TODO about this somewhere in the
code, but I don't see a TODO being removed.  Looking around, I guess not.

Could some of the duplication between Tx.Query and DB.Query be removed?
 I've only done a quick review.


On Sun, Jan 13, 2013 at 5:53 PM, <google@julienschmidt.com> wrote:

> Reviewers: ,
>
> Message:
> All test pass with $GOROOT/src/all.bash. Also tested with
>
https://github.com/bradfitz/**go-sql-test<https://github.com/bradfitz/go-sql-...
my reference implementation
> of the Queryer-Interface (Should it be named Querier?) for my
> MySQL-Driver:
> https://github.com/**JulienSchmidt/Go-MySQL-Driver/**commit/**
>
60ced5014af9b63a725feb8d73065b**295d4fe377<https://github.com/JulienSchmidt/Go-MySQL-Driver/commit/60ced5014af9b63a725feb8d73065b295d4fe377>
>
> Description:
> database/sql: Add an optional Queryer-Interface (like Execer)
>
> Completly the same like the Execer-Interface, just for Queries.
> This allows Drivers the execute Queries without preparing them first
>
> Please review this at
https://codereview.appspot.**com/7085056/<https://codereview.appspot.com/7085...
>
> Affected files:
>   M src/pkg/database/sql/driver/**driver.go
>   M src/pkg/database/sql/fakedb_**test.go
>   M src/pkg/database/sql/sql.go
>
>
>

[julienschmidt, 2013-01-19 17:25:42]

Thanks Brad,

I wrote about the missing interface on golang-nuts a while ago but I didn't find
a TODO or a related Issue.

Yes, Tx.Query and DB.Query are basically the same, except for grabbing the
connection and the release-function.
I'll write a helper-function tomorrow.

On 2013/01/19 17:03:13, bradfitz wrote:
> Sorry for the slow review... I was backlogged.
> 
> This looks nice.  I thought there was a TODO about this somewhere in the
> code, but I don't see a TODO being removed.  Looking around, I guess not.
> 
> Could some of the duplication between Tx.Query and DB.Query be removed?
>  I've only done a quick review.
> 
> 
> On Sun, Jan 13, 2013 at 5:53 PM, <mailto:google@julienschmidt.com> wrote:
> 
> > Reviewers: ,
> >
> > Message:
> > All test pass with $GOROOT/src/all.bash. Also tested with
> >
>
https://github.com/bradfitz/**go-sql-test%3Chttps://github.com/bradfitz/go-sq...
> my reference implementation
> > of the Queryer-Interface (Should it be named Querier?) for my
> > MySQL-Driver:
> > https://github.com/**JulienSchmidt/Go-MySQL-Driver/**commit/**
> >
>
60ced5014af9b63a725feb8d73065b**295d4fe377<https://github.com/JulienSchmidt/Go-MySQL-Driver/commit/60ced5014af9b63a725feb8d73065b295d4fe377>
> >
> > Description:
> > database/sql: Add an optional Queryer-Interface (like Execer)
> >
> > Completly the same like the Execer-Interface, just for Queries.
> > This allows Drivers the execute Queries without preparing them first
> >
> > Please review this at
>
https://codereview.appspot.**com/7085056/%3Chttps://codereview.appspot.com/70...>
> >
> > Affected files:
> >   M src/pkg/database/sql/driver/**driver.go
> >   M src/pkg/database/sql/fakedb_**test.go
> >   M src/pkg/database/sql/sql.go
> >
> >
> >

[julienschmidt, 2013-01-21 22:55:42]

Hello golang-dev@googlegroups.com (cc: bradfitz@golang.org,
golang-dev@googlegroups.com),

Please take another look.

[julienschmidt, 2013-01-21 23:04:58]

Just wondering, the function signature got quite long ... too long?
Do you have any Code Conventions for that?

[julienschmidt, 2013-02-06 20:42:08]

Is there a chance that this makes it into Go 1.1?

[bradfitz, 2013-02-06 21:00:18]

I think this is still in scope. It started before the cut.

I've just been sucking at database/sql maintenance.
 On Feb 6, 2013 12:42 PM, <google@julienschmidt.com> wrote:

> Is there a chance that this makes it into Go 1.1?
>
>
https://codereview.appspot.**com/7085056/<https://codereview.appspot.com/7085...
>

[bradfitz, 2013-02-13 23:25:21]

LGTM

[bradfitz, 2013-02-13 23:26:33]

*** Submitted as https://code.google.com/p/go/source/detail?r=9b7b9fa92d2c ***

database/sql: Add an optional Queryer-Interface (like Execer)

Completly the same like the Execer-Interface, just for Queries.
This allows Drivers to execute Queries without preparing them first

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/7085056

Committer: Brad Fitzpatrick <bradfitz@golang.org>