Issue 7080043: charm: don't check hook names

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7080043: charm: don't check hook names

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by fwereade

Modified:
11 years, 3 months ago

Reviewers:
mp+142738, rog, TheMue

Visibility:
Public.

Description

charm: don't check hook names This would break on encountering charms with valid juju-* relation hooks https://code.launchpad.net/~fwereade/juju-core/fix-hook-name-checks/+merge/142738 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : charm: don't check hook names #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -43 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	charm/bundle.go	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	charm/bundle_test.go	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	charm/charm.go	View	2 chunks	+0 lines, -11 lines	0 comments	Download
M	charm/dir.go	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	charm/dir_test.go	View	1 chunk	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rog

On 2013/01/10 17:29:13, fwereade wrote: > Please take a look. LGTM

11 years, 3 months ago (2013-01-10 17:30:53 UTC) #2

fwereade

11 years, 3 months ago (2013-01-10 17:33:10 UTC) #4

*** Submitted:

charm: don't check hook names

This would break on encountering charms with valid juju-* relation hooks

R=rog, TheMue
CC=
https://codereview.appspot.com/7080043

Expand All Messages | Collapse All Messages