code review 70800043: net/http: in Client, consume small redirect bodies befo...

net/http: in Client, consume small redirect bodies before making next request

In Go 1.2, closing a request body without reading to EOF
causes the underlying TCP connection to not be reused. This
client code following redirects was never updated when that
happened.

This was part of a previous CL but moved to its own CL at
Josh's request.  Now with test too.

[bradfitz, 2014-03-03 16:18:24]

Hello josharian@gmail.com (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[josharian, 2014-03-03 19:04:10]

LGTM

Thanks for splitting this out, giving it a good commit message, and adding a
test. Much clearer.

[bradfitz, 2014-03-03 19:25:59]

*** Submitted as https://code.google.com/p/go/source/detail?r=7257b771f12b ***

net/http: in Client, consume small redirect bodies before making next request

In Go 1.2, closing a request body without reading to EOF
causes the underlying TCP connection to not be reused. This
client code following redirects was never updated when that
happened.

This was part of a previous CL but moved to its own CL at
Josh's request.  Now with test too.

LGTM=josharian
R=josharian
CC=golang-codereviews
https://codereview.appspot.com/70800043

[gobot, 2014-03-03 19:29:31]

This CL appears to have broken the solaris-amd64-solaris11 builder.