charm: juju-* relation names sometimes allowed

charm: juju-* relation names sometimes allowed

Specifically: container-scoped require relations of subordinate charms may
use juju-* names for relations; they're disallowed for everything else.

https://code.launchpad.net/~fwereade/juju-core/charm-relax-require-namespace/+merge/142699

(do not edit description out of merge proposal)

[fwereade, 2013-01-10 14:22:24]

Please take a look.

[TheMue, 2013-01-10 14:34:29]

LGTM, only one hint.

https://codereview.appspot.com/7073056/diff/1/charm/meta.go
File charm/meta.go (right):

https://codereview.appspot.com/7073056/diff/1/charm/meta.go#newcode85
charm/meta.go:85: collect := func(src map[string]Relation, isRequire bool) error
{
Name should be something with check, because you mentioned above that it checks,
not collects.

[rog, 2013-01-10 16:24:43]

seems plausible, although i can't say i fully understand the ins and outs of
this issue. have you checked that this does allow some previously unrunnable
charms to work live. that would be great...

LGTM

https://codereview.appspot.com/7073056/diff/1/charm/meta.go
File charm/meta.go (right):

https://codereview.appspot.com/7073056/diff/1/charm/meta.go#newcode76
charm/meta.go:76: meta.Subordinate = m["subordinate"].(bool)
s/m["subordinate"]/subordinate/

https://codereview.appspot.com/7073056/diff/1/charm/meta.go#newcode85
charm/meta.go:85: collect := func(src map[string]Relation, isRequire bool) error
{
On 2013/01/10 14:34:29, TheMue wrote:
> Name should be something with check, because you mentioned above that it
checks,
> not collects.

+1

[fwereade, 2013-01-10 17:09:28]

*** Submitted:

charm: juju-* relation names sometimes allowed

Specifically: container-scoped require relations of subordinate charms may
use juju-* names for relations; they're disallowed for everything else.

R=TheMue, rog
CC=
https://codereview.appspot.com/7073056

https://codereview.appspot.com/7073056/diff/1/charm/meta.go
File charm/meta.go (right):

https://codereview.appspot.com/7073056/diff/1/charm/meta.go#newcode76
charm/meta.go:76: meta.Subordinate = m["subordinate"].(bool)
On 2013/01/10 16:24:43, rog wrote:
> s/m["subordinate"]/subordinate/

Done.

https://codereview.appspot.com/7073056/diff/1/charm/meta.go#newcode85
charm/meta.go:85: collect := func(src map[string]Relation, isRequire bool) error
{
On 2013/01/10 16:24:43, rog wrote:
> On 2013/01/10 14:34:29, TheMue wrote:
> > Name should be something with check, because you mentioned above that it
> checks,
> > not collects.
> 
> +1

Done.