Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4458)

Issue 7073051: Make charm work without environment Juju PPA

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by gary.poster
Modified:
11 years, 3 months ago
Reviewers:
mp+142568, matthew.scott
Visibility:
Public.

Description

Make charm work without environment Juju PPA As discovered by therve and myself, the charm does not work if "juju-origin: ppa" is not in your environments.yaml for the given Juju environment. These changes work around the problem. https://code.launchpad.net/~gary/charms/precise/juju-gui/run-without-ppa/+merge/142568 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Make charm work without environment Juju PPA #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -1 line) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
A hooks/bootstrap_utils.py View 1 chunk +54 lines, -0 lines 0 comments Download
M hooks/install View 1 chunk +8 lines, -0 lines 0 comments Download
M revision View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
gary.poster
Please take a look.
11 years, 3 months ago (2013-01-09 18:21:04 UTC) #1
matthew.scott
LGTM, thanks for the work-around. No changes here, but I do have a question: will ...
11 years, 3 months ago (2013-01-09 22:54:48 UTC) #2
gary.poster
On 2013/01/09 22:54:48, matthew.scott wrote: > LGTM, thanks for the work-around. No changes here, but ...
11 years, 3 months ago (2013-01-10 00:36:39 UTC) #3
frankban
Land as is. Thanks for this workaround Gary. This review is made by Nicola and ...
11 years, 3 months ago (2013-01-10 11:04:57 UTC) #4
gary.poster
11 years, 3 months ago (2013-01-10 13:12:19 UTC) #5
*** Submitted:

Make charm work without environment Juju PPA

As discovered by therve and myself, the charm does not work if "juju-origin:
ppa" is not in your environments.yaml for the given Juju environment.  These
changes work around the problem.

R=matthew.scott, frankban
CC=
https://codereview.appspot.com/7073051
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b