Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(34)

Issue 70720043: code review 70720043: syscall: update NetBSD/ARM port to EABI. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by minux1
Modified:
11 years, 3 months ago
Reviewers:
gobot, jsing
CC:
golang-codereviews, jsing
Visibility:
Public.

Description

syscall: update NetBSD/ARM port to EABI.

Patch Set 1 #

Patch Set 2 : diff -r 63f448126b28 https://code.google.com/p/go #

Patch Set 3 : diff -r 63f448126b28 https://code.google.com/p/go #

Total comments: 1

Patch Set 4 : diff -r 877a41585fc7 https://code.google.com/p/go #

Patch Set 5 : diff -r 877a41585fc7 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -13 lines) Patch
M src/pkg/syscall/zsyscall_netbsd_arm.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/syscall/ztypes_netbsd_arm.go View 1 6 chunks +17 lines, -12 lines 0 comments Download

Messages

Total messages: 7
minux1
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
11 years, 3 months ago (2014-03-03 08:10:36 UTC) #1
jsing
LGTM https://codereview.appspot.com/70720043/diff/40001/src/pkg/syscall/zsyscall_netbsd_arm.go File src/pkg/syscall/zsyscall_netbsd_arm.go (right): https://codereview.appspot.com/70720043/diff/40001/src/pkg/syscall/zsyscall_netbsd_arm.go#newcode1 src/pkg/syscall/zsyscall_netbsd_arm.go:1: // mksyscall.pl -l32 -arm syscall_bsd.go syscall_netbsd.go syscall_netbsd_arm.go Should ...
11 years, 3 months ago (2014-03-03 11:35:48 UTC) #2
minux1
*** Submitted as https://code.google.com/p/go/source/detail?r=4e58a371558f *** syscall: update NetBSD/ARM port to EABI. LGTM=jsing R=golang-codereviews, jsing CC=golang-codereviews ...
11 years, 3 months ago (2014-03-06 05:56:04 UTC) #3
minux1
On 2014/03/03 11:35:48, jsing wrote: > https://codereview.appspot.com/70720043/diff/40001/src/pkg/syscall/zsyscall_netbsd_arm.go#newcode1 > src/pkg/syscall/zsyscall_netbsd_arm.go:1: // mksyscall.pl -l32 -arm > syscall_bsd.go ...
11 years, 3 months ago (2014-03-06 05:58:35 UTC) #4
minux1
On 2014/03/06 05:58:35, minux wrote: > On 2014/03/03 11:35:48, jsing wrote: > > > https://codereview.appspot.com/70720043/diff/40001/src/pkg/syscall/zsyscall_netbsd_arm.go#newcode1 ...
11 years, 3 months ago (2014-03-06 06:00:33 UTC) #5
gobot
This CL appears to have broken the darwin-amd64 builder.
11 years, 3 months ago (2014-03-06 06:03:39 UTC) #6
minux1
11 years, 3 months ago (2014-03-06 06:05:55 UTC) #7
On Thu, Mar 6, 2014 at 1:03 AM, <gobot@golang.org> wrote:

> This CL appears to have broken the darwin-amd64 builder
>
this is real. I need to do something in api/except.txt.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b