Issue 7071051: cmd/jujud: factor out run loop

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7071051: cmd/jujud: factor out run loop

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by rog

Modified:
11 years, 3 months ago

Reviewers:
mp+142320

Visibility:
Public.

Description

cmd/jujud: factor out run loop Gets rid of a fair amount of duplicated code, and makes it possible to test the run loop independently of the agents too (reserved for a future CL). https://code.launchpad.net/~rogpeppe/juju-core/183-jujud-runloop/+merge/142320 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : cmd/jujud: factor out run loop #

Patch Set 3 : cmd/jujud: factor out run loop #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+100 lines, -90 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/jujud/agent.go	View	2 chunks	+58 lines, -0 lines	0 comments	Download
M	cmd/jujud/machine.go	View	3 chunks	+15 lines, -45 lines	0 comments	Download
M	cmd/jujud/unit.go	View	2 chunks	+15 lines, -45 lines	0 comments	Download
M	cmd/jujud/upgrade.go	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/jujud/upgrade_test.go	View	1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

dimitern

On 2013/01/08 14:16:36, rog wrote: > Please take a look. LGTM

11 years, 3 months ago (2013-01-08 14:28:40 UTC) #4

TheMue

Yeah, makes it more clear. So LGTM. Only want comments on the Agent interface method ...

11 years, 3 months ago (2013-01-08 14:29:19 UTC) #5

rog

11 years, 3 months ago (2013-01-08 14:47:19 UTC) #6

*** Submitted:

cmd/jujud: factor out run loop

Gets rid of a fair amount of duplicated code, and makes it
possible to test the run loop independently of the agents
too (reserved for a future CL).

R=fwereade, dimitern, TheMue
CC=
https://codereview.appspot.com/7071051

Expand All Messages | Collapse All Messages