Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3799)

Issue 7070069: Add location annotations for service drags.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by bac
Modified:
11 years, 3 months ago
Reviewers:
mp+142756, bcsaller
Visibility:
Public.

Description

Add location annotations for service drags. When a service block is moved, the location annotation is updated when the drag event ends. https://code.launchpad.net/~bac/juju-gui/1096273/+merge/142756 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 3

Patch Set 2 : Add location annotations for service drags. #

Patch Set 3 : Add location annotations for service drags. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -31 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M app/views/topology/service.js View 1 10 chunks +41 lines, -28 lines 0 comments Download
M test/index.html View 1 chunk +1 line, -0 lines 0 comments Download
M test/test_d3_components.js View 2 chunks +1 line, -3 lines 0 comments Download
A test/test_service_module.js View 1 1 chunk +78 lines, -0 lines 0 comments Download

Messages

Total messages: 5
bac
Please take a look.
11 years, 4 months ago (2013-01-10 18:57:20 UTC) #1
gary.poster
Land as is, if Ben confirms that the event registration is OK. :-) Looks good. ...
11 years, 4 months ago (2013-01-10 19:05:09 UTC) #2
bac
Please take a look.
11 years, 3 months ago (2013-01-10 20:06:30 UTC) #3
bcsaller
LGTM, thanks https://codereview.appspot.com/7070069/diff/1/app/views/topology/service.js File app/views/topology/service.js (right): https://codereview.appspot.com/7070069/diff/1/app/views/topology/service.js#newcode267 app/views/topology/service.js:267: topo.get('env').update_annotations(d.id, {x: d.x, y: d.y}); That came ...
11 years, 3 months ago (2013-01-10 20:35:52 UTC) #4
bac
11 years, 3 months ago (2013-01-10 20:42:05 UTC) #5
*** Submitted:

Add location annotations for service drags.

When a service block is moved, the location annotation is updated when the
drag event ends.

R=gary.poster, bcsaller
CC=
https://codereview.appspot.com/7070069
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b