Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(705)

Issue 7068048: code review 7068048: container/heap: revise example and add a si... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by cespare
Modified:
11 years, 1 month ago
Reviewers:
CC:
rsc, adg, golang-dev
Visibility:
Public.

Description

container/heap: revise example and add a simpler example. This adds a simple IntHeap example, and modifies the more complex PriorityQueue example to make use of the index field it maintains. Fixes issue 4331.

Patch Set 1 #

Patch Set 2 : diff -r 94f0ce1a6b70 https://code.google.com/p/go #

Patch Set 3 : diff -r 49db9317937c https://code.google.com/p/go #

Total comments: 2

Patch Set 4 : diff -r 1b57fb106d8d https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -126 lines) Patch
M src/pkg/container/heap/example_intheap_test.go View 1 2 chunks +27 lines, -84 lines 0 comments Download
M src/pkg/container/heap/example_pq_test.go View 1 2 3 2 chunks +36 lines, -41 lines 0 comments Download
M src/pkg/container/heap/heap.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
cespare
Hello golang-dev@googlegroups.com (cc: rsc@golang.org), I'd like you to review this change to https://code.google.com/p/go
11 years, 2 months ago (2013-01-07 04:50:29 UTC) #1
rsc
Looks good, thanks. https://codereview.appspot.com/7068048/diff/4001/src/pkg/container/heap/example_pq_test.go File src/pkg/container/heap/example_pq_test.go (right): https://codereview.appspot.com/7068048/diff/4001/src/pkg/container/heap/example_pq_test.go#newcode33 src/pkg/container/heap/example_pq_test.go:33: pq[i].index, pq[j].index = i, j Please ...
11 years, 2 months ago (2013-01-18 20:08:24 UTC) #2
cespare
PTAL. https://codereview.appspot.com/7068048/diff/4001/src/pkg/container/heap/example_pq_test.go File src/pkg/container/heap/example_pq_test.go (right): https://codereview.appspot.com/7068048/diff/4001/src/pkg/container/heap/example_pq_test.go#newcode33 src/pkg/container/heap/example_pq_test.go:33: pq[i].index, pq[j].index = i, j On 2013/01/18 20:08:24, ...
11 years, 2 months ago (2013-01-18 21:00:29 UTC) #3
rsc
11 years, 1 month ago (2013-01-31 07:14:32 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=2ea8f07b2ffe ***

container/heap: split example into two

This adds a simple IntHeap example, and modifies the more complex
PriorityQueue example to make use of the index field it maintains.

Fixes issue 4331.

R=rsc, adg
CC=golang-dev
https://codereview.appspot.com/7068048

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b