Use recess as CSS linter

Use recess as CSS linter

This is the first step to implementing a CSS linter (recess).  Currently, most of the options are turned off in order to keep this slack task short, so our LESS file passes the linter.  Further slack tasks may be created for options that we decide to turn on down the road (personal suggestions: noOverqualifying and zeroUnits, ambivalent about strictPropertyOrder).

https://code.launchpad.net/~makyo/juju-gui/recess/+merge/142572

(do not edit description out of merge proposal)

[matthew.scott, 2013-01-09 18:46:15]

Please take a look.

[gary.poster, 2013-01-09 22:10:24]

land with changes.

Please apply the diff I gave, or do something similar.  You don't need to do
anything about lib/templates.js.  Let's stick with what you have.

Thank you!

Gary

https://codereview.appspot.com/7067057/diff/1/Makefile
File Makefile (right):

https://codereview.appspot.com/7067057/diff/1/Makefile#newcode227
Makefile:227: recess lib/views/stylesheet.less --config recess.json | grep -q
Perfect
This runs a global "recess" and not the one installed locally. 
http://pastebin.ubuntu.com/1514675/ has a fix for this.

https://codereview.appspot.com/7067057/diff/1/Makefile#newcode465
Makefile:465: undocumented yuidoc yuidoc-lint
recess is a "PHONY" target because there is no "recess" file in the root of the
build.  The pastebin also has this change.  http://pastebin.ubuntu.com/1514675/

https://codereview.appspot.com/7067057/diff/1/lib/templates.js
File lib/templates.js (right):

https://codereview.appspot.com/7067057/diff/1/lib/templates.js#newcode191
lib/templates.js:191: });
I wonder about this change, but I am OK with it.  Simply using less and relying
on recess for later linting might be nicer.  OTOH, maybe this keeps us from
falling over when the LESS file is bad.

[teknico, 2013-01-10 14:31:31]

Land with (Gary's) changes.

No comments in addition to Gary's ones, this looks great, thanks.

[matthew.scott, 2013-01-10 16:41:32]

Thanks for the reviews.

https://codereview.appspot.com/7067057/diff/1/Makefile
File Makefile (right):

https://codereview.appspot.com/7067057/diff/1/Makefile#newcode227
Makefile:227: recess lib/views/stylesheet.less --config recess.json | grep -q
Perfect
On 2013/01/09 22:10:24, gary.poster wrote:
> This runs a global "recess" and not the one installed locally. 
> http://pastebin.ubuntu.com/1514675/ has a fix for this.

Good catch!  Had it installed globally for testing and had forgotten.  Applied
the patch.

https://codereview.appspot.com/7067057/diff/1/lib/templates.js
File lib/templates.js (right):

https://codereview.appspot.com/7067057/diff/1/lib/templates.js#newcode191
lib/templates.js:191: });
On 2013/01/09 22:10:24, gary.poster wrote:
> I wonder about this change, but I am OK with it.  Simply using less and
relying
> on recess for later linting might be nicer.  OTOH, maybe this keeps us from
> falling over when the LESS file is bad.

I reverted this change.  recess just uses less to compile, and if the LESS file
is bad, the error we get is the error from the less package.  No real value
added.

[matthew.scott, 2013-01-10 16:45:49]

*** Submitted:

Use recess as CSS linter

This is the first step to implementing a CSS linter (recess).  Currently, most
of the options are turned off in order to keep this slack task short, so our
LESS file passes the linter.  Further slack tasks may be created for options
that we decide to turn on down the road (personal suggestions: noOverqualifying
and zeroUnits, ambivalent about strictPropertyOrder).

R=gary.poster, teknico
CC=
https://codereview.appspot.com/7067057