Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1166)

Issue 7067056: cmd/jujud: fix run loop to work reliably in tests

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by rog
Modified:
11 years, 2 months ago
Reviewers:
mp+142496
Visibility:
Public.

Description

cmd/jujud: fix run loop to work reliably in tests Various tests assume that the agent will get to run at least once, even though it's killed immediately. This change makes sure that it will. https://code.launchpad.net/~rogpeppe/juju-core/185-jujud-fix-test-race/+merge/142496 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : cmd/jujud: fix run loop to work reliably in tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/jujud/agent.go View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 4
rog
Please take a look.
11 years, 2 months ago (2013-01-09 12:37:33 UTC) #1
TheMue
LGTM
11 years, 2 months ago (2013-01-09 12:39:32 UTC) #2
jameinel
On 2013/01/09 12:39:32, TheMue wrote: > LGTM LGTM
11 years, 2 months ago (2013-01-09 12:48:34 UTC) #3
rog
11 years, 2 months ago (2013-01-09 14:01:24 UTC) #4
*** Submitted:

cmd/jujud: fix run loop to work reliably in tests

Various tests assume that the agent will get to run
at least once, even though it's killed immediately.
This change makes sure that it will.

R=TheMue, jameinel
CC=
https://codereview.appspot.com/7067056
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b