Issue 7067056: cmd/jujud: fix run loop to work reliably in tests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7067056: cmd/jujud: fix run loop to work reliably in tests

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by rog

Modified:
13 years, 1 month ago

Reviewers:
mp+142496

Visibility:
Public.

Description

cmd/jujud: fix run loop to work reliably in tests Various tests assume that the agent will get to run at least once, even though it's killed immediately. This change makes sure that it will. https://code.launchpad.net/~rogpeppe/juju-core/185-jujud-fix-test-race/+merge/142496 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : cmd/jujud: fix run loop to work reliably in tests #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -1 line)			Patch
	A	[revision details]	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	cmd/jujud/agent.go	View		2 chunks	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rog

13 years, 1 month ago (2013-01-09 14:01:24 UTC) #4

*** Submitted:

cmd/jujud: fix run loop to work reliably in tests

Various tests assume that the agent will get to run
at least once, even though it's killed immediately.
This change makes sure that it will.

R=TheMue, jameinel
CC=
https://codereview.appspot.com/7067056

Expand All Messages | Collapse All Messages