Issue 7067052: code review 7067052: cmd/8g, cmd/dist, cmd/gc: fix warnings on Plan 9

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7067052: code review 7067052: cmd/8g, cmd/dist, cmd/gc: fix warnings on Plan 9 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by ality

Modified:
12 years, 6 months ago

Reviewers:

CC:
golang-dev, akumar, rsc

Visibility:
Public.

Description

cmd/8g, cmd/dist, cmd/gc: fix warnings on Plan 9 cmd/8g/gsubr.c: unreachable code cmd/8g/reg.c: overspecifed class cmd/dist/plan9.c: unused parameter cmd/gc/fmt.c: stkdelta is now a vlong cmd/gc/racewalk.c: used but not set

Patch Set 1 #

Patch Set 2 : diff -r 66b0356aa14c https://code.google.com/p/go/ #

Patch Set 3 : diff -r 66b0356aa14c https://code.google.com/p/go/ #

Patch Set 4 : diff -r 845f6e3bb306 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 845f6e3bb306 https://code.google.com/p/go/ #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -6 lines)			Patch
M	src/cmd/8g/gsubr.c	View	1	2 chunks	+1 line, -4 lines	0 comments	Download
M	src/cmd/8g/reg.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/dist/plan9.c	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/gc/fmt.c	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/gc/racewalk.c	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

ality

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

12 years, 6 months ago (2013-01-08 00:47:47 UTC) #1

ality

Submitting. I added one more fix after updating to tip. One of Rémy's changesets made ...

12 years, 6 months ago (2013-01-19 03:07:01 UTC) #4

ality

12 years, 6 months ago (2013-01-19 03:08:09 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=b14680735334 ***

cmd/8g, cmd/dist, cmd/gc: fix warnings on Plan 9

cmd/8g/gsubr.c: unreachable code
cmd/8g/reg.c: overspecifed class
cmd/dist/plan9.c: unused parameter
cmd/gc/fmt.c: stkdelta is now a vlong
cmd/gc/racewalk.c: used but not set

R=golang-dev, seed, rsc
CC=golang-dev
https://codereview.appspot.com/7067052

Expand All Messages | Collapse All Messages