Prevent duplicate nodes in services.

Prevent duplicate nodes in services.

drawService was being called for all nodes on update, which was appending new nodes to the DOM (for the most part invisibly, but still not good).  Instead, new services are filled with the empty requisites for a service block, and then the internals are updated on update to match the DB.  A further step (not taken here for time's sake) would be to only update services affected by the update call.  Additionally, some comments were out of date, and these were cleaned up.

https://code.launchpad.net/~makyo/juju-gui/duplicates-1095761/+merge/142202

(do not edit description out of merge proposal)

[matthew.scott, 2013-01-07 21:10:17]

Please take a look.

[gary.poster, 2013-01-08 02:57:11]

Land with changes

Hi Matt.  Looks good to me.  Thank you for the simplifications.  I have trivial
indentation suggestions that you may ignore if desired.

Did you consider whether we could test this so it would not happen again?  That
would be nice.

Thanks

Gary

https://codereview.appspot.com/7066050/diff/1/app/views/topology/mega.js
File app/views/topology/mega.js (left):

https://codereview.appspot.com/7066050/diff/1/app/views/topology/mega.js#oldc...
app/views/topology/mega.js:408: })
FWIW, this indentation looked nicer to me.

https://codereview.appspot.com/7066050/diff/1/app/views/topology/mega.js#oldc...
app/views/topology/mega.js:463: })
nicer indent here.

https://codereview.appspot.com/7066050/diff/1/app/views/topology/mega.js#oldc...
app/views/topology/mega.js:466: })
this indentation is nicer here too, I think.

https://codereview.appspot.com/7066050/diff/1/app/views/topology/mega.js#oldc...
app/views/topology/mega.js:483: })
nicer indent before

https://codereview.appspot.com/7066050/diff/1/app/views/topology/mega.js#oldc...
app/views/topology/mega.js:486: })
nicer indent before

https://codereview.appspot.com/7066050/diff/1/app/views/topology/mega.js#oldc...
app/views/topology/mega.js:591: });
indent was nicer before I think.

https://codereview.appspot.com/7066050/diff/1/undocumented
File undocumented (left):

https://codereview.appspot.com/7066050/diff/1/undocumented#oldcode210
undocumented:210: app/views/topology/mega.js:378 "drawService"
thank you!

[matthew.scott, 2013-01-08 16:22:48]

Indentation brought more closely in line with what appears elsewhere in d3-land
within the app.  I'm not totally happy with it, and would be willing to change
further if needed.  Also, added a test, though it's rather specific to this bug.
 Even so, it's now tested.

[matthew.scott, 2013-01-08 16:22:51]

Please take a look.

[bcsaller, 2013-01-08 16:26:56]

This looks like a great improvement, thanks.

+1

[matthew.scott, 2013-01-08 16:50:50]

*** Submitted:

Prevent duplicate nodes in services.

drawService was being called for all nodes on update, which was appending new
nodes to the DOM (for the most part invisibly, but still not good).  Instead,
new services are filled with the empty requisites for a service block, and then
the internals are updated on update to match the DB.  A further step (not taken
here for time's sake) would be to only update services affected by the update
call.  Additionally, some comments were out of date, and these were cleaned up.

R=gary.poster, bcsaller
CC=
https://codereview.appspot.com/7066050