Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(352)

Issue 7066050: Prevent duplicate nodes in services.

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 9 months ago by matthew.scott
Modified:
7 years, 9 months ago
Reviewers:
mp+142202
Visibility:
Public.

Description

Prevent duplicate nodes in services. drawService was being called for all nodes on update, which was appending new nodes to the DOM (for the most part invisibly, but still not good). Instead, new services are filled with the empty requisites for a service block, and then the internals are updated on update to match the DB. A further step (not taken here for time's sake) would be to only update services affected by the update call. Additionally, some comments were out of date, and these were cleaned up. https://code.launchpad.net/~makyo/juju-gui/duplicates-1095761/+merge/142202 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 7

Patch Set 2 : Prevent duplicate nodes in services. #

Patch Set 3 : Prevent duplicate nodes in services. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+267 lines, -198 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M app/views/topology/mega.js View 1 1 chunk +218 lines, -196 lines 0 comments Download
M test/test_environment_view.js View 1 2 chunks +47 lines, -1 line 0 comments Download
M undocumented View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6
matthew.scott
Please take a look.
7 years, 9 months ago (2013-01-07 21:10:17 UTC) #1
gary.poster
Land with changes Hi Matt. Looks good to me. Thank you for the simplifications. I ...
7 years, 9 months ago (2013-01-08 02:57:11 UTC) #2
matthew.scott
Indentation brought more closely in line with what appears elsewhere in d3-land within the app. ...
7 years, 9 months ago (2013-01-08 16:22:48 UTC) #3
matthew.scott
Please take a look.
7 years, 9 months ago (2013-01-08 16:22:51 UTC) #4
bcsaller
This looks like a great improvement, thanks. +1
7 years, 9 months ago (2013-01-08 16:26:56 UTC) #5
matthew.scott
7 years, 9 months ago (2013-01-08 16:50:50 UTC) #6
*** Submitted:

Prevent duplicate nodes in services.

drawService was being called for all nodes on update, which was appending new
nodes to the DOM (for the most part invisibly, but still not good).  Instead,
new services are filled with the empty requisites for a service block, and then
the internals are updated on update to match the DB.  A further step (not taken
here for time's sake) would be to only update services affected by the update
call.  Additionally, some comments were out of date, and these were cleaned up.

R=gary.poster, bcsaller
CC=
https://codereview.appspot.com/7066050
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b