Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(115)

Issue 7064060: Add support for _annotation calls to env.

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 9 months ago by bac
Modified:
7 years, 9 months ago
Reviewers:
mp+142513, hazmat
Visibility:
Public.

Description

Add support for _annotation calls to env. The calls update_annotations, get_annotations, and remove_annotations are added to the env object. As a drive-by, in test_env.js the unnecessary use of async calls was eliminated by removing the 'done' parameter. Leaving it in place where not required was confusing. https://code.launchpad.net/~bac/juju-gui/1096230/+merge/142513 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add support for _annotation calls to env. #

Total comments: 1

Patch Set 3 : Add support for _annotation calls to env. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -15 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M app/store/env.js View 1 2 1 chunk +52 lines, -1 line 0 comments Download
M test/test_env.js View 9 chunks +42 lines, -14 lines 0 comments Download

Messages

Total messages: 5
bac
Please take a look.
7 years, 9 months ago (2013-01-09 13:40:57 UTC) #1
gary.poster
Land with changes. Looks good to me. Thank you! Gary https://codereview.appspot.com/7064060/diff/1/app/store/env.js File app/store/env.js (right): https://codereview.appspot.com/7064060/diff/1/app/store/env.js#newcode276 ...
7 years, 9 months ago (2013-01-09 13:57:41 UTC) #2
bac
Please take a look.
7 years, 9 months ago (2013-01-09 14:36:02 UTC) #3
hazmat
lgtm, one minor of note https://codereview.appspot.com/7064060/diff/5001/app/store/env.js File app/store/env.js (right): https://codereview.appspot.com/7064060/diff/5001/app/store/env.js#newcode296 app/store/env.js:296: * callback. The invocation ...
7 years, 9 months ago (2013-01-09 14:42:11 UTC) #4
bac
7 years, 9 months ago (2013-01-09 15:01:02 UTC) #5
*** Submitted:

Add support for _annotation calls to env.

The calls update_annotations, get_annotations, and remove_annotations are
added to the env object.

As a drive-by, in test_env.js the unnecessary use of async calls was
eliminated by removing the 'done' parameter.  Leaving it in place where not
required was confusing.

R=gary.poster, hazmat
CC=
https://codereview.appspot.com/7064060
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b