Add support for _annotation calls to env.

Add support for _annotation calls to env.

The calls update_annotations, get_annotations, and remove_annotations are
added to the env object.

As a drive-by, in test_env.js the unnecessary use of async calls was
eliminated by removing the 'done' parameter.  Leaving it in place where not
required was confusing.

https://code.launchpad.net/~bac/juju-gui/1096230/+merge/142513

(do not edit description out of merge proposal)

[bac, 2013-01-09 13:40:57]

Please take a look.

[gary.poster, 2013-01-09 13:57:41]

Land with changes.

Looks good to me.  Thank you!

Gary

https://codereview.appspot.com/7064060/diff/1/app/store/env.js
File app/store/env.js (right):

https://codereview.appspot.com/7064060/diff/1/app/store/env.js#newcode276
app/store/env.js:276: * @param {Object} entity The name of a machine, unit,
service, or
Would be nice to specify what the name of these things is--examples.

https://codereview.appspot.com/7064060/diff/1/app/store/env.js#newcode307
app/store/env.js:307: *   environment.
You don't describe the keys argument.  Given that it appears to be optional, it
would be particularly nice to document.

[bac, 2013-01-09 14:36:02]

Please take a look.

[hazmat, 2013-01-09 14:42:11]

lgtm, one minor of note

https://codereview.appspot.com/7064060/diff/5001/app/store/env.js
File app/store/env.js (right):

https://codereview.appspot.com/7064060/diff/5001/app/store/env.js#newcode296
app/store/env.js:296: *   callback.  The invocation of this command returns
nothing.
the doc string should also have a note that annotations come back in the delta
stream so explicit fetching should be rarely be needed or unesc.

[bac, 2013-01-09 15:01:02]

*** Submitted:

Add support for _annotation calls to env.

The calls update_annotations, get_annotations, and remove_annotations are
added to the env object.

As a drive-by, in test_env.js the unnecessary use of async calls was
eliminated by removing the 'done' parameter.  Leaving it in place where not
required was confusing.

R=gary.poster, hazmat
CC=
https://codereview.appspot.com/7064060