Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(684)

Issue 70640043: code review 70640043: cmd/dist: support building pkg/runtime/*. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by minux1
Modified:
11 years ago
Reviewers:
rsc
CC:
golang-codereviews, rsc
Visibility:
Public.

Description

cmd/dist: support building pkg/runtime/*. Essentialy for running tests without a working cmd/go. While we're at it, also fix a typo.

Patch Set 1 #

Patch Set 2 : diff -r 6c3aba695d87 https://code.google.com/p/go #

Patch Set 3 : diff -r 6c3aba695d87 https://code.google.com/p/go #

Patch Set 4 : diff -r 11209a881ff0 https://code.google.com/p/go #

Patch Set 5 : diff -r 11209a881ff0 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/cmd/dist/build.c View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M src/cmd/dist/buildruntime.c View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
minux1
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
11 years ago (2014-03-03 00:31:21 UTC) #1
minux1
The reason behind this change is that somehow I broke cmd/go badly, and I want ...
11 years ago (2014-03-03 00:42:28 UTC) #2
rsc
LGTM This CL is fine, but I want to point out that in this case ...
11 years ago (2014-03-05 19:09:07 UTC) #3
minux1
On Wed, Mar 5, 2014 at 2:09 PM, <rsc@golang.org> wrote: > This CL is fine, ...
11 years ago (2014-03-05 19:54:59 UTC) #4
minux1
11 years ago (2014-03-05 19:57:20 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=d2efd9207d51 ***

cmd/dist: support building pkg/runtime/*.
Essentialy for running tests without a working cmd/go.
While we're at it, also fix a typo.

LGTM=rsc
R=golang-codereviews, rsc
CC=golang-codereviews
https://codereview.appspot.com/70640043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b