state: change unit *Address methods

state: change unit *Address methods

...to return (string, bool) instead of (string, error), as discussed and
agreed to be a good idea some time ago; did the same to appropriate
jujuc.Context methods.

https://code.launchpad.net/~fwereade/juju-core/unit-address-methods/+merge/142548

(do not edit description out of merge proposal)

[fwereade, 2013-01-09 16:20:09]

Please take a look.

[TheMue, 2013-01-09 16:23:41]

Don't know the reason anymore, so would like a little summary here. But the code
itself LGTM.

[rog, 2013-01-09 16:24:47]

LGTM assuming HookContext.*Address fixed in the same way, and with a suggestion
for some simplification.

https://codereview.appspot.com/7063055/diff/1/state/unit.go
File state/unit.go (right):

https://codereview.appspot.com/7063055/diff/1/state/unit.go#newcode244
state/unit.go:244: if u.doc.PublicAddress == "" {
return u.doc.PublicAddress, u.doc.PublicAddress != ""
?

https://codereview.appspot.com/7063055/diff/1/state/unit.go#newcode252
state/unit.go:252: if u.doc.PrivateAddress == "" {
as above

https://codereview.appspot.com/7063055/diff/1/worker/uniter/context.go
File worker/uniter/context.go (right):

https://codereview.appspot.com/7063055/diff/1/worker/uniter/context.go#newcode59
worker/uniter/context.go:59: func (ctx *HookContext) PublicAddress() (string,
error) {
shouldn't this follow the same scheme?

then this function could just be:
return ctx.unit.PublicAddress()

https://codereview.appspot.com/7063055/diff/1/worker/uniter/context.go#newcode67
worker/uniter/context.go:67: func (ctx *HookContext) PrivateAddress() (string,
error) {
as above

[fwereade, 2013-01-09 16:32:13]

On 2013/01/09 16:23:41, TheMue wrote:
> Don't know the reason anymore, so would like a little summary here. But the
code
> itself LGTM.

There's only one error that can be returned, and it's a little uncomfortable
because it tends to lead to error messages with repeated unit names; when
DeployerName was added it became apparent that the *Address methods should
follow the same scheme.

[fwereade, 2013-01-09 16:58:31]

*** Submitted:

state: change unit *Address methods

...to return (string, bool) instead of (string, error), as discussed and
agreed to be a good idea some time ago; did the same to appropriate
jujuc.Context methods.

R=TheMue, rog
CC=
https://codereview.appspot.com/7063055

https://codereview.appspot.com/7063055/diff/1/state/unit.go
File state/unit.go (right):

https://codereview.appspot.com/7063055/diff/1/state/unit.go#newcode244
state/unit.go:244: if u.doc.PublicAddress == "" {
On 2013/01/09 16:24:47, rog wrote:
> return u.doc.PublicAddress, u.doc.PublicAddress != ""
> ?

Done.

https://codereview.appspot.com/7063055/diff/1/state/unit.go#newcode252
state/unit.go:252: if u.doc.PrivateAddress == "" {
On 2013/01/09 16:24:47, rog wrote:
> as above

Done.

https://codereview.appspot.com/7063055/diff/1/worker/uniter/context.go
File worker/uniter/context.go (right):

https://codereview.appspot.com/7063055/diff/1/worker/uniter/context.go#newcode59
worker/uniter/context.go:59: func (ctx *HookContext) PublicAddress() (string,
error) {
On 2013/01/09 16:24:47, rog wrote:
> shouldn't this follow the same scheme?
> 
> then this function could just be:
> return ctx.unit.PublicAddress()

Done.

https://codereview.appspot.com/7063055/diff/1/worker/uniter/context.go#newcode67
worker/uniter/context.go:67: func (ctx *HookContext) PrivateAddress() (string,
error) {
On 2013/01/09 16:24:47, rog wrote:
> as above

Done.