Issue 7062062: uniter: set subordinates to Dying

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7062062: uniter: set subordinates to Dying

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by fwereade

Modified:
11 years, 3 months ago

Reviewers:
rog, mp+142673, TheMue

Visibility:
Public.

Description

uniter: set subordinates to Dying ...once the principal agent is Dying. https://code.launchpad.net/~fwereade/juju-core/subordinates-cascade-principal-dying/+merge/142673 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : uniter: set subordinates to Dying #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -16 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/service_test.go	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	state/unit.go	View	1	1 chunk	+5 lines, -3 lines	0 comments	Download
M	worker/uniter/modes.go	View	1	2 chunks	+13 lines, -1 line	0 comments	Download
M	worker/uniter/uniter_test.go	View	1	2 chunks	+27 lines, -8 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rog

LGTM with one simplification below https://codereview.appspot.com/7062062/diff/1/state/unit.go File state/unit.go (right): https://codereview.appspot.com/7062062/diff/1/state/unit.go#newcode227 state/unit.go:227: func (u *Unit) SubordinateNames() ...

11 years, 3 months ago (2013-01-10 12:04:13 UTC) #3

fwereade

11 years, 3 months ago (2013-01-10 15:56:37 UTC) #4

*** Submitted:

uniter: set subordinates to Dying

...once the principal agent is Dying.

R=TheMue, rog
CC=
https://codereview.appspot.com/7062062

https://codereview.appspot.com/7062062/diff/1/state/unit.go
File state/unit.go (right):

https://codereview.appspot.com/7062062/diff/1/state/unit.go#newcode227
state/unit.go:227: func (u *Unit) SubordinateNames() (names []string) {
On 2013/01/10 12:04:13, rog wrote:
> names := make([]string, len(u.doc.Subordinates)
> copy(names, u.doc.Subordinates)
> return names

Done.

Expand All Messages | Collapse All Messages