code review 7060056: misc/emacs: update go-mode syntax table and comment han...

misc/emacs: update go-mode syntax table and comment handling as
suggested by pkleiweg.

Fixes issue 3471.

[Sameer Ajmani, 2013-01-08 20:48:58]

Hello adonovan@google.com, pkleiweg@gmail.com, rsc (cc: golang-dev,
golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[adonovan, 2013-01-08 22:12:31]

This looks plausible but it's too subtle to guess at the behaviour change from
the code alone.  How did you validate it?

[Sameer Ajmani, 2013-01-08 22:48:36]

Tested manually on the test case listed in the issue and on another source
file I have that exhibits the same problem. Both fixed.
On Jan 8, 2013 5:12 PM, <adonovan@google.com> wrote:

> This looks plausible but it's too subtle to guess at the behaviour
> change from the code alone.  How did you validate it?
>
>
https://codereview.appspot.**com/7060056/<https://codereview.appspot.com/7060...
>

[Sameer Ajmani, 2013-01-09 14:52:54]

Tested successfully using GNU Emacs 23.3.1 and XEmacs 21.4 (patch 22) using the
following source:

// I am a comment.
func foo() {
	files, err := filepath.Glob(dir + "/*")
	if err != nil {
		return err
	}
}

// I am /*also*/ a comment.
var butIAmNot bool

/* So, too, am I a comment. */
var noYouAreNot bool

/* //Yes!  Yes I am! */
var nope bool



On 2013/01/08 22:48:36, Sameer Ajmani wrote:
> Tested manually on the test case listed in the issue and on another source
> file I have that exhibits the same problem. Both fixed.
> On Jan 8, 2013 5:12 PM, <mailto:adonovan@google.com> wrote:
> 
> > This looks plausible but it's too subtle to guess at the behaviour
> > change from the code alone.  How did you validate it?
> >
> >
>
https://codereview.appspot.**com/7060056/%3Chttps://codereview.appspot.com/70...>
> >

[adonovan, 2013-01-09 15:22:58]

LGTM

Thanks, that's what I was looking for.


On 9 January 2013 09:52, <sameer@golang.org> wrote:

> Tested successfully using GNU Emacs 23.3.1 and XEmacs 21.4 (patch 22)
> using the following source:
>
> // I am a comment.
> func foo() {
>         files, err := filepath.Glob(dir + "/*")
>         if err != nil {
>                 return err
>         }
> }
>
> // I am /*also*/ a comment.
> var butIAmNot bool
>
> /* So, too, am I a comment. */
> var noYouAreNot bool
>
> /* //Yes!  Yes I am! */
> var nope bool
>
>
>
>
> On 2013/01/08 22:48:36, Sameer Ajmani wrote:
>
>> Tested manually on the test case listed in the issue and on another
>>
> source
>
>> file I have that exhibits the same problem. Both fixed.
>> On Jan 8, 2013 5:12 PM, <mailto:adonovan@google.com> wrote:
>>
>
>  > This looks plausible but it's too subtle to guess at the behaviour
>> > change from the code alone.  How did you validate it?
>> >
>> >
>>
>
> https://codereview.appspot.****com/7060056/%3Chttps://coderev**
> iew.appspot.com/7060056/ <http://codereview.appspot.com/7060056/>>
>
>> >
>>
>
>
>
https://codereview.appspot.**com/7060056/<https://codereview.appspot.com/7060...
>

[Sameer Ajmani, 2013-01-09 15:27:35]

*** Submitted as https://code.google.com/p/go/source/detail?r=486ac1caa5c3 ***

misc/emacs: update go-mode syntax table and comment handling as
suggested by pkleiweg.

Fixes issue 3471.

R=adonovan, pkleiweg, rsc
CC=golang-dev
https://codereview.appspot.com/7060056