code review 7060046: go.net/publicsuffix: distinguish ICANN domains from pri...

go.net/publicsuffix: distinguish ICANN domains from private domains;
add a publicsuffix.PublicSuffix function.

This required moving the encoded node type bits from the nodes array
to the children array.

[nigeltao, 2013-01-06 07:24:09]

Hello dr.volker.dobler@gmail.com (cc: golang-dev@googlegroups.com,
rsc@golang.org, rsleevi@chromium.org),

I'd like you to review this change to
https://code.google.com/p/go.net

[rsc, 2013-01-06 19:48:18]

LGTM

https://codereview.appspot.com/7060046/diff/4001/publicsuffix/gen.go
File publicsuffix/gen.go (right):

https://codereview.appspot.com/7060046/diff/4001/publicsuffix/gen.go#newcode131
publicsuffix/gen.go:131: } else if strings.Contains(s, "END ICANN DOMAINS") {
no else after body that does not fall through

https://codereview.appspot.com/7060046/diff/4001/publicsuffix/gen.go#newcode134
publicsuffix/gen.go:134: } else if s == "" || strings.HasPrefix(s, "//") {
no else

[volker.dobler, 2013-01-07 10:04:50]

LGTM

https://codereview.appspot.com/7060046/diff/4001/publicsuffix/list.go
File publicsuffix/list.go (right):

https://codereview.appspot.com/7060046/diff/4001/publicsuffix/list.go#newcode83
publicsuffix/list.go:83: // We assume that such a TLD is an ICANN TLD.
Unsure about this: a TLD of "intranet" or something
alike is common but not really an ICANN TLD.
I would return icann=false.

[nigeltao, 2013-01-08 10:16:55]

https://codereview.appspot.com/7060046/diff/4001/publicsuffix/list.go
File publicsuffix/list.go (right):

https://codereview.appspot.com/7060046/diff/4001/publicsuffix/list.go#newcode83
publicsuffix/list.go:83: // We assume that such a TLD is an ICANN TLD.
On 2013/01/07 10:04:50, volker.dobler wrote:
> Unsure about this: a TLD of "intranet" or something
> alike is common but not really an ICANN TLD.
> I would return icann=false.

I added a foundTLD variable to PublicSuffix and a "foo.intranet" test case to
TestICANN. PTAL.

[volker.dobler, 2013-01-08 11:49:55]

LGTM

[nigeltao, 2013-01-09 11:10:13]

https://codereview.appspot.com/7060046/diff/8002/publicsuffix/list.go
File publicsuffix/list.go (right):

https://codereview.appspot.com/7060046/diff/8002/publicsuffix/list.go#newcode85
publicsuffix/list.go:85: return domain[1+strings.LastIndex(domain, "."):],
foundTLD
On second thoughts,
return etc, foundTLD
can be just
return etc, icann
and it doesn't really matter in practice, but that's probably more correct. I'll
submit that.

[nigeltao, 2013-01-09 11:11:35]

*** Submitted as
https://code.google.com/p/go/source/detail?r=e1c4b7341527&repo=net ***

go.net/publicsuffix: distinguish ICANN domains from private domains;
add a publicsuffix.PublicSuffix function.

This required moving the encoded node type bits from the nodes array
to the children array.

R=dr.volker.dobler, rsc
CC=golang-dev, rsleevi
https://codereview.appspot.com/7060046