Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4407)

Issue 7058067: http issues 80 & 180: Delete some headers on a redirect & handle relative location (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by yanivi
Modified:
10 years, 2 months ago
Reviewers:
ngmiceli, ccalli
CC:
rmistry
Base URL:
https://code.google.com/p/google-http-java-client/
Visibility:
Public.

Description

http issues 80 & 180: Delete some headers on a redirect & handle relative location http://code.google.com/p/google-http-java-client/issues/detail?id=180 Delete some headers on a redirect http://code.google.com/p/google-http-java-client/issues/detail?id=80 NullPointerException if redirect location is relative

Patch Set 1 #

Patch Set 2 : cleaner implementation #

Patch Set 3 : cleaner implementation #

Patch Set 4 : minor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -15 lines) Patch
M google-http-client/src/main/java/com/google/api/client/http/GenericUrl.java View 1 2 3 3 chunks +48 lines, -6 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/http/HttpHeaders.java View 2 chunks +28 lines, -0 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/http/HttpRequest.java View 1 2 chunks +21 lines, -7 lines 0 comments Download
M google-http-client/src/test/java/com/google/api/client/http/HttpRequestTest.java View 1 chunk +45 lines, -2 lines 0 comments Download

Messages

Total messages: 4
yanivi
11 years, 3 months ago (2013-01-09 22:07:06 UTC) #1
ngmiceli
LGTM
11 years, 3 months ago (2013-01-10 21:27:03 UTC) #2
ccalli
On 2013/01/10 21:27:03, ngmiceli wrote: > LGTM Any developments on this?
10 years, 2 months ago (2014-02-17 22:12:12 UTC) #3
ccalli
10 years, 2 months ago (2014-02-17 22:47:29 UTC) #4
Message was sent while issue was closed.
On 2014/02/17 22:12:12, ccalli wrote:
> On 2013/01/10 21:27:03, ngmiceli wrote:
> > LGTM
> 
> Any developments on this?

Wrong post, please ignore.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b