Issue 7058053: code review 7058053: cmd/dist: drop unneeded clang flags

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7058053: code review 7058053: cmd/dist: drop unneeded clang flags (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by dave

Modified:
12 years, 6 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

cmd/dist: drop unneeded clang flags Our source no longer needs these flags set to build cleanly using clang. Tested with * Ubuntu clang version 3.0-6ubuntu3 (tags/RELEASE_30/final) (based on LLVM 3.0) on i386 * clang version 3.2 (tags/RELEASE_32/final) on amd64 cross compiling all platforms

Patch Set 1 #

Patch Set 2 : diff -r 66b0356aa14c https://code.google.com/p/go #

Patch Set 3 : diff -r 66b0356aa14c https://code.google.com/p/go #

Patch Set 4 : diff -r 66b0356aa14c https://code.google.com/p/go #

Patch Set 5 : diff -r eb1f4df73e31 https://code.google.com/p/go #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -4 lines)			Patch
	M	src/cmd/dist/build.c	View	1 2	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dave_cheney.net

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

12 years, 6 months ago (2013-01-08 02:48:02 UTC) #1

dave_cheney.net

12 years, 6 months ago (2013-01-09 21:00:15 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=5f1eb036b64a ***

cmd/dist: drop unneeded clang flags

Our source no longer needs these flags set to build cleanly using clang.

Tested with

* Ubuntu clang version 3.0-6ubuntu3 (tags/RELEASE_30/final) (based on LLVM 3.0)
on i386
* clang version 3.2 (tags/RELEASE_32/final) on amd64 cross compiling all
platforms

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/7058053

Expand All Messages | Collapse All Messages