code review 7057058: cmd/ld: fix incompatible type signatures on Plan 9

cmd/ld: fix incompatible type signatures on Plan 9

Changeset f483bfe81114 moved ELF generation to the architecture
independent code and in doing so added a Section* to the Sym
type and an Elf64_Shdr* to the Section type.

This caused the Plan 9 compilers to complain about incompatible
type signatures in the many files that reference the Sym type.

[ality, 2013-01-08 00:10:52]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[dave_cheney.net, 2013-01-08 00:16:33]

https://codereview.appspot.com/7057058/diff/4001/src/cmd/ld/symtab.c
File src/cmd/ld/symtab.c (right):

https://codereview.appspot.com/7057058/diff/4001/src/cmd/ld/symtab.c#newcode128
src/cmd/ld/symtab.c:128: off = putelfstr(s);
I think this needs a comment, otherwise someone will clean it up down the track
and break plan9 again.

[rsc, 2013-01-09 18:58:45]

NOT LGTM

No thank you.
To fix Plan 9, add

#pragma incomplete Elf64_Shdr

to the top of lib.h.

[ality, 2013-01-09 20:57:22]

Hello rsc@golang.org, dave@cheney.net (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2013-01-09 20:58:32]

LGTM

[ality, 2013-01-09 23:05:31]

*** Submitted as https://code.google.com/p/go/source/detail?r=7a9044a3bdc8 ***

cmd/ld: fix incompatible type signatures on Plan 9

Changeset f483bfe81114 moved ELF generation to the architecture
independent code and in doing so added a Section* to the Sym
type and an Elf64_Shdr* to the Section type.

This caused the Plan 9 compilers to complain about incompatible
type signatures in the many files that reference the Sym type.

R=rsc, dave
CC=golang-dev
https://codereview.appspot.com/7057058