Issue 7057052: code review 7057052: cmd/go: use filepath.SplitList when inspecting GOPATH

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7057052: code review 7057052: cmd/go: use filepath.SplitList when inspecting GOPATH (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by dave

Modified:
11 years, 3 months ago

Reviewers:

CC:
adg, iant, golang-dev

Visibility:
Public.

Description

cmd/go: use filepath.SplitList when inspecting GOPATH There exists a test case for this condition, but it only runs on unix systems, which neatly dovetails into the code always using ':' as the list separator.

Patch Set 1 #

Patch Set 2 : diff -r 28af76d9a25b https://code.google.com/p/go #

Patch Set 3 : diff -r 28af76d9a25b https://code.google.com/p/go #

Patch Set 4 : diff -r 8906cf341c9b https://go.googlecode.com/hg/ #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/cmd/go/main.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dave_cheney.net

Hello adg@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 3 months ago (2013-01-07 05:06:12 UTC) #1

dave_cheney.net

On 2013/01/07 20:33:51, iant wrote: > LGTM Thank you Ian.

11 years, 3 months ago (2013-01-07 22:46:13 UTC) #3

dave_cheney.net

11 years, 3 months ago (2013-01-07 23:00:55 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=c529f87b63d1 ***

cmd/go: use filepath.SplitList when inspecting GOPATH

There exists a test case for this condition, but it only runs on unix systems,
which neatly dovetails into the code always using ':' as the list separator.

R=adg, iant
CC=golang-dev
https://codereview.appspot.com/7057052

Expand All Messages | Collapse All Messages