Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(168)

Issue 7057048: code review 7057048: go/doc: trim only first space or newline from example o... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years ago by adg
Modified:
9 years ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

go/doc: trim only first space or newline from example output comment Fixes issue 4487.

Patch Set 1 #

Patch Set 2 : diff -r 24319fed0324 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M src/pkg/go/doc/example.go View 1 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 7
adg
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
9 years ago (2013-01-07 02:18:19 UTC) #1
rsc
LGTM Make it 'zero or more spaces followed by \n or a single space'.
9 years ago (2013-01-07 02:25:54 UTC) #2
adg
*** Submitted as https://code.google.com/p/go/source/detail?r=94f0ce1a6b70 *** go/doc: trim only first space or newline from example output ...
9 years ago (2013-01-07 02:44:38 UTC) #3
adg
On 7 January 2013 13:44, <adg@golang.org> wrote: > go/doc: trim only first space or newline ...
9 years ago (2013-01-07 02:47:47 UTC) #4
rsc
The code looks like it strips all leading spaces up to the first non-space, eating ...
9 years ago (2013-01-07 03:42:08 UTC) #5
adg
On 7 January 2013 14:42, Russ Cox <rsc@golang.org> wrote: > The code looks like it ...
9 years ago (2013-01-07 03:51:40 UTC) #6
rsc
9 years ago (2013-01-07 03:53:11 UTC) #7
I was suggesting / | +\n/ but you did / *\n?/. Yours is probably better.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b