Makes protobuf support Tru64 (hopefully). This is a minor revision of your patch. I don't have access to a Tru64 system, so if you can test this for me that'd be great.
Thanks for getting that form through! It will be nice to get this patch in. ...
15 years, 5 months ago
(2008-11-13 20:26:06 UTC)
#3
Thanks for getting that form through! It will be nice to get this patch in.
Unfortunately I just noticed another problem that slipped by before...
http://codereview.appspot.com/7041/diff/1/3
File src/gtest/internal/gtest-internal.h (left):
http://codereview.appspot.com/7041/diff/1/3#oldcode243
Line 243: inline String FormatForFailureMessage(const T& value) {
On review, I've discovered that removing this function definition actually
creates a whole ton of warnings and incorrect behavior in when tests fail. So,
we can't remove this.
If we leave this function here, does compiling on Tru64 fail? Is it the same
problem that is mentioned above for the Symbian compiler? Can we reuse that
solution?
Issue 7041: Support Tru64 in protobuf
Created 15 years, 7 months ago by kenton
Modified 14 years, 9 months ago
Reviewers: choiniere.vincent
Base URL: http://protobuf.googlecode.com/svn/trunk/
Comments: 1