Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5697)

Issue 7040048: code review 7040048: exp/gotype: skip tests on freebsd/arm (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by dave
Modified:
11 years, 3 months ago
Reviewers:
minux1, rsc, gri
CC:
golang-dev
Visibility:
Public.

Description

exp/gotype: skip tests on freebsd/arm The freebsd/arm builder has such poor IO bandwidth that it cannot complete this test within the 120 seconds allocated. Temporarily disable the test until a better kernel is available.

Patch Set 1 #

Patch Set 2 : diff -r 6867d442bb3d https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 6867d442bb3d https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 6867d442bb3d https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M src/pkg/exp/gotype/gotype_test.go View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8
dave_cheney.net
Hello minux.ma@gmail.com, gri@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 3 months ago (2013-01-03 12:56:22 UTC) #1
dave_cheney.net
Robert, Minux, I would like to skip the test exp/types on freebsd/arm so we have ...
11 years, 3 months ago (2013-01-03 13:00:17 UTC) #2
minux1
On Thu, Jan 3, 2013 at 9:00 PM, <dave@cheney.net> wrote: > I would like to ...
11 years, 3 months ago (2013-01-03 13:45:28 UTC) #3
dave_cheney.net
> Sure. LGTM. > At least go/types is now passing with our extensive debugging prints. ...
11 years, 3 months ago (2013-01-03 22:04:04 UTC) #4
dave_cheney.net
I was able to jerry rig an external USB hard drive to this host, which ...
11 years, 3 months ago (2013-01-04 11:24:08 UTC) #5
rsc
A better solution would be to reduce the test cost for all systems, by excluding ...
11 years, 3 months ago (2013-01-04 15:11:02 UTC) #6
dave_cheney.net
It looks like the overnight builds passed. I attached a USB hard drive to the ...
11 years, 3 months ago (2013-01-04 22:57:55 UTC) #7
dave_cheney.net
11 years, 3 months ago (2013-01-05 03:12:15 UTC) #8
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b