Issue 7039056: uniter: wait for subordinates while terminating

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7039056: uniter: wait for subordinates while terminating

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by fwereade

Modified:
11 years, 4 months ago

Reviewers:
mp+141945, rog

Visibility:
Public.

Description

uniter: wait for subordinates while terminating https://code.launchpad.net/~fwereade/juju-core/uniter-wait-subordinates-dead/+merge/141945 Requires: https://code.launchpad.net/~fwereade/juju-core/unit-death-restrictions/+merge/141930 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+54 lines, -5 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	worker/uniter/modes.go	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	worker/uniter/uniter_test.go	View	5 chunks	+50 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rog

On 2013/01/04 15:52:07, fwereade wrote: > Please take a look. The description of this CL ...

11 years, 4 months ago (2013-01-07 13:47:43 UTC) #2

fwereade

11 years, 4 months ago (2013-01-07 14:47:36 UTC) #3

On 2013/01/07 13:47:43, rog wrote:
> On 2013/01/04 15:52:07, fwereade wrote:
> > Please take a look.
> 
> The description of this CL doesn't seem to tally with its content. (the prereq
> CL added the code to wait for subordinates).

Sorry, I should have added an explicit rejection notice here, not just in LP and
the prereq.

Expand All Messages | Collapse All Messages