Fix release process documentation

Fix release process documentation

And other minor changes, like text formatting fixes 
and trailing spaces removal.

https://code.launchpad.net/~frankban/juju-gui/release-process-fixes/+merge/141738

(do not edit description out of merge proposal)

[frankban, 2013-01-03 11:51:03]

Please take a look.

[teknico, 2013-01-03 12:06:30]

Land with (small) changes.

https://codereview.appspot.com/7039049/diff/1/docs/process.rst
File docs/process.rst (right):

https://codereview.appspot.com/7039049/diff/1/docs/process.rst#newcode109
docs/process.rst:109: - If you are using a pre-existing branch, make sure it is
up-to-date::
No need for double colons in the two lines above.

https://codereview.appspot.com/7039049/diff/1/docs/process.rst#newcode128
docs/process.rst:128: - In the ``build-prod`` directory, inside the uncompressed
one, start a server:
s/inside/under/

https://codereview.appspot.com/7039049/diff/1/docs/process.rst#newcode183
docs/process.rst:183: - If you are using a pre-existing branch, make sure it is
up-to-date::
No need for double colons in the two lines above.

[frankban, 2013-01-03 13:30:35]

Thanks for the review Nicola.

https://codereview.appspot.com/7039049/diff/1/docs/process.rst
File docs/process.rst (right):

https://codereview.appspot.com/7039049/diff/1/docs/process.rst#newcode109
docs/process.rst:109: - If you are using a pre-existing branch, make sure it is
up-to-date::
On 2013/01/03 12:06:30, teknico wrote:
> No need for double colons in the two lines above.

Done.

https://codereview.appspot.com/7039049/diff/1/docs/process.rst#newcode128
docs/process.rst:128: - In the ``build-prod`` directory, inside the uncompressed
one, start a server:
On 2013/01/03 12:06:30, teknico wrote:
> s/inside/under/

Done.

https://codereview.appspot.com/7039049/diff/1/docs/process.rst#newcode183
docs/process.rst:183: - If you are using a pre-existing branch, make sure it is
up-to-date::
On 2013/01/03 12:06:30, teknico wrote:
> No need for double colons in the two lines above.

Done.

[frankban, 2013-01-03 13:31:18]

Please take a look.

[benji, 2013-01-03 14:01:52]

Thank you for fixing these instructions up.  I had a couple of comments that
should be addressed.  After that this looks eminently landable.

https://codereview.appspot.com/7039049/diff/4002/docs/process.rst
File docs/process.rst (right):

https://codereview.appspot.com/7039049/diff/4002/docs/process.rst#newcode123
docs/process.rst:123: ``FINAL=1 make test-debug``.
Do you really need "FINAL=1" for tests?  The last time I looked at the Makefile
it didn't change the way tests worked.

https://codereview.appspot.com/7039049/diff/4002/docs/process.rst#newcode128
docs/process.rst:128: - In the ``build-prod`` directory, under the uncompressed
one, start a server:
I can't parse this.  The "under the uncompressed one" part is what throws me
off.  I /think/ this is what it should say: "While still in the directory where
you extracted the tar file, change to the build-prod directory and start a
server:..."

That might be better as two steps: one to change to the directory and one to
start the server.

https://codereview.appspot.com/7039049/diff/4002/docs/process.rst#newcode196
docs/process.rst:196: - In the ``build-prod`` directory, start a server:
Should this line should be identical to the parallel step in the stable release
instructions (line 128)?

[frankban, 2013-01-03 14:53:45]

Thanks Benji.

https://codereview.appspot.com/7039049/diff/4002/docs/process.rst
File docs/process.rst (right):

https://codereview.appspot.com/7039049/diff/4002/docs/process.rst#newcode123
docs/process.rst:123: ``FINAL=1 make test-debug``.
On 2013/01/03 14:01:52, benji wrote:
> Do you really need "FINAL=1" for tests?  The last time I looked at the
Makefile
> it didn't change the way tests worked.

As discussed on IRC, I'll leave this workaround waiting for
https://bugs.launchpad.net/juju-gui/+bug/1095663 to be fixed.

https://codereview.appspot.com/7039049/diff/4002/docs/process.rst#newcode128
docs/process.rst:128: - In the ``build-prod`` directory, under the uncompressed
one, start a server:
On 2013/01/03 14:01:52, benji wrote:
> I can't parse this.  The "under the uncompressed one" part is what throws me
> off.  I /think/ this is what it should say: "While still in the directory
where
> you extracted the tar file, change to the build-prod directory and start a
> server:..."
> 
> That might be better as two steps: one to change to the directory and one to
> start the server.

Done.

https://codereview.appspot.com/7039049/diff/4002/docs/process.rst#newcode196
docs/process.rst:196: - In the ``build-prod`` directory, start a server:
On 2013/01/03 14:01:52, benji wrote:
> Should this line should be identical to the parallel step in the stable
release
> instructions (line 128)?

You are right, done.

[frankban, 2013-01-03 14:57:03]

*** Submitted:

Fix release process documentation

And other minor changes, like text formatting fixes 
and trailing spaces removal.

R=teknico, benji
CC=
https://codereview.appspot.com/7039049