Issue 7036050: code review 7036050: log/syslog: remove RFC5424 version number for greater c...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7036050: code review 7036050: log/syslog: remove RFC5424 version number for greater c... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by jgc

Modified:
11 years, 3 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

log/syslog: remove RFC5424 version number for greater compatibility RFC5424 specifies a version number (currently 1) after the facility and severity in a syslog message (e.g. <7>1 TIMESTAMP ...). This causes rsyslog to fail to parse syslog message because the rest of the message is not fully compliant with RFC5424. For the widest compatibility, drop the version (messages are in the RFC3164 BSD syslog format (e.g. <7>TIMESTAMP ...). Have tested this with syslog-ng, rsyslog and syslogd.

Patch Set 1 #

Patch Set 2 : diff -r d0d76b7fb219 https://code.google.com/p/go #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -10 lines)			Patch
	M	src/pkg/log/syslog/syslog.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
	M	src/pkg/log/syslog/syslog_test.go	View	1	2 chunks	+8 lines, -8 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

jgc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

11 years, 3 months ago (2013-01-04 14:46:05 UTC) #1

rsc

11 years, 3 months ago (2013-01-04 15:21:44 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=9b60bbb9814d ***

log/syslog: remove RFC5424 version number for greater compatibility

RFC5424 specifies a version number (currently 1) after the facility and
severity in a syslog message (e.g. <7>1 TIMESTAMP ...).  This causes
rsyslog to fail to parse syslog message because the rest of the message
is not fully compliant with RFC5424.

For the widest compatibility, drop the version (messages are in the
RFC3164 BSD syslog format (e.g. <7>TIMESTAMP ...). Have tested this with
syslog-ng, rsyslog and syslogd.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/7036050

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages