http issue 178: Move PrivateKeys from OAuth project into SecurityUtils

http issue 178: Move PrivateKeys from OAuth project into SecurityUtils
https://code.google.com/p/google-http-java-client/issues/detail?id=178

http issue 176: Ability to restrict the trusted CAs 
https://code.google.com/p/google-http-java-client/issues/detail?id=176

[ngmiceli, 2013-01-04 15:08:07]

https://codereview.appspot.com/7034050/diff/9/google-http-client/src/main/jav...
File
google-http-client/src/main/java/com/google/api/client/http/apache/SSLSocketFactoryImpl.java
(right):

https://codereview.appspot.com/7034050/diff/9/google-http-client/src/main/jav...
google-http-client/src/main/java/com/google/api/client/http/apache/SSLSocketFactoryImpl.java:35:
class SSLSocketFactoryImpl extends SSLSocketFactory {
Why the name change? Doesn't this still accept all certs? If so, the previous
name was perfectly descriptive of what the class does and the danger of using it
(should) be perfectly clear even without reading the javadoc.  If it doesn't
anymore, then the above documentation should be updated.

https://codereview.appspot.com/7034050/diff/9/google-http-client/src/test/jav...
File
google-http-client/src/test/java/com/google/api/client/util/SecurityUtilsTest.java
(right):

https://codereview.appspot.com/7034050/diff/9/google-http-client/src/test/jav...
google-http-client/src/test/java/com/google/api/client/util/SecurityUtilsTest.java:76:
assertTrue(Arrays.equals(ENCODED, actualEncoded));
Use jUnit's assertArrayEquals(byte[], byte[]). 
Similarly below

[yanivi, 2013-01-07 21:13:28]

I also added the ability to load certificates from PEM file.  Please take a look
again.

https://codereview.appspot.com/7034050/diff/9/google-http-client/src/main/jav...
File
google-http-client/src/main/java/com/google/api/client/http/apache/SSLSocketFactoryImpl.java
(right):

https://codereview.appspot.com/7034050/diff/9/google-http-client/src/main/jav...
google-http-client/src/main/java/com/google/api/client/http/apache/SSLSocketFactoryImpl.java:35:
class SSLSocketFactoryImpl extends SSLSocketFactory {
On 2013/01/04 15:08:08, ngmiceli wrote:
> Why the name change? Doesn't this still accept all certs? If so, the previous
> name was perfectly descriptive of what the class does and the danger of using
it
> (should) be perfectly clear even without reading the javadoc.  If it doesn't
> anymore, then the above documentation should be updated.

I don't know what I was thinking.  The whole SSLSocketFactory extension is
entirely unnecessary because SSLSocketFactory already has the functionality we
need.  Class removed entirely.

https://codereview.appspot.com/7034050/diff/9/google-http-client/src/test/jav...
File
google-http-client/src/test/java/com/google/api/client/util/SecurityUtilsTest.java
(right):

https://codereview.appspot.com/7034050/diff/9/google-http-client/src/test/jav...
google-http-client/src/test/java/com/google/api/client/util/SecurityUtilsTest.java:76:
assertTrue(Arrays.equals(ENCODED, actualEncoded));
On 2013/01/04 15:08:08, ngmiceli wrote:
> Use jUnit's assertArrayEquals(byte[], byte[]). 
> Similarly below 

Done.

[ngmiceli, 2013-01-08 22:03:10]

LGTM

One optional thought below

https://codereview.appspot.com/7034050/diff/29001/google-http-client/src/test...
File
google-http-client/src/test/java/com/google/api/client/util/SecurityUtilsTest.java
(right):

https://codereview.appspot.com/7034050/diff/29001/google-http-client/src/test...
google-http-client/src/test/java/com/google/api/client/util/SecurityUtilsTest.java:18:
import org.junit.Assert;
[Optional] I prefer reading 
import static org.junit.Assert.assertArrayEquals;
which removes the need for the preceding Assert before assertArrayEquals. Just
my opinion