code review 7034049: misc/dashboard/builder: set GOPATH before building subrepos

misc/dashboard/builder: set GOPATH before building subrepos

This proposal updates the dashboard builder to avoid relying on the (soon to be removed) support for using go get to download to $GOROOT. The result is

WORKSPACE=$(the value of the -buildRoot flag / $BUILDER_NAME + hg revision)
GOROOT=$WORKSPACE/go
GOPATH=$WORKSPACE

Required for CL 6941058.

[dfc, 2013-01-03 22:11:27]

Hello minux.ma@gmail.com, adg@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[adg, 2013-01-06 21:28:11]

https://codereview.appspot.com/7034049/diff/8001/misc/dashboard/builder/main.go
File misc/dashboard/builder/main.go (right):

https://codereview.appspot.com/7034049/diff/8001/misc/dashboard/builder/main....
misc/dashboard/builder/main.go:356: env[i] = p +
above this

sep := string(os.PathListSeparator)
env[i] = p + filepath.Join(goRoot, "bin") + sep + filepath.Join(goPath, "bin") +
sep + e[len(p):]

https://codereview.appspot.com/7034049/diff/8001/misc/dashboard/builder/main....
misc/dashboard/builder/main.go:368: return log, err
yay

[adg, 2013-01-06 21:28:19]

LGTM

[dfc, 2013-01-06 23:10:26]

Thank you for your comments.

https://codereview.appspot.com/7034049/diff/8001/misc/dashboard/builder/main.go
File misc/dashboard/builder/main.go (right):

https://codereview.appspot.com/7034049/diff/8001/misc/dashboard/builder/main....
misc/dashboard/builder/main.go:356: env[i] = p +
On 2013/01/06 21:28:11, adg wrote:
> above this
> 
> sep := string(os.PathListSeparator)
> env[i] = p + filepath.Join(goRoot, "bin") + sep + filepath.Join(goPath, "bin")
+
> sep + e[len(p):]

Much clearer, done.

[dfc, 2013-01-07 00:24:31]

*** Submitted as https://code.google.com/p/go/source/detail?r=b6f92bf40bb8 ***

misc/dashboard/builder: set GOPATH before building subrepos

This proposal updates the dashboard builder to avoid relying on the (soon to be
removed) support for using go get to download to $GOROOT. The result is

WORKSPACE=$(the value of the -buildRoot flag / $BUILDER_NAME + hg revision)
GOROOT=$WORKSPACE/go
GOPATH=$WORKSPACE

Required for CL 6941058.

R=minux.ma, adg
CC=golang-dev
https://codereview.appspot.com/7034049