Issue 7033053: Removed no longer needed workaround.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7033053: Removed no longer needed workaround.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by frankban

Modified:
11 years, 3 months ago

Reviewers:
mp+141923

Visibility:
Public.

Description

Removed no longer needed workaround. The file app/models/charm.js was added explicitly in bin/merge-files. Apparently this workaround is no longer required: the file is correctly collected by lib/merge-files.js:readdir. https://code.launchpad.net/~frankban/juju-gui/bug-1090563-merge-files/+merge/141923 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Removed no longer needed workaround. #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	A	[revision details]	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	bin/merge-files	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

frankban

11 years, 3 months ago (2013-01-04 15:58:17 UTC) #4

*** Submitted:

Removed no longer needed workaround.

The file app/models/charm.js was added explicitly 
in bin/merge-files. Apparently this workaround
is no longer required: the file is correctly
collected by lib/merge-files.js:readdir.

R=gary.poster, teknico
CC=
https://codereview.appspot.com/7033053

Expand All Messages | Collapse All Messages