Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(65)

Issue 7033053: Removed no longer needed workaround.

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 9 months ago by frankban
Modified:
7 years, 9 months ago
Reviewers:
mp+141923
Visibility:
Public.

Description

Removed no longer needed workaround. The file app/models/charm.js was added explicitly in bin/merge-files. Apparently this workaround is no longer required: the file is correctly collected by lib/merge-files.js:readdir. https://code.launchpad.net/~frankban/juju-gui/bug-1090563-merge-files/+merge/141923 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Removed no longer needed workaround. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M bin/merge-files View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4
frankban
Please take a look.
7 years, 9 months ago (2013-01-04 14:30:41 UTC) #1
gary.poster
Land as is Thank you! Gary
7 years, 9 months ago (2013-01-04 15:06:49 UTC) #2
teknico
Land as is.
7 years, 9 months ago (2013-01-04 15:25:57 UTC) #3
frankban
7 years, 9 months ago (2013-01-04 15:58:17 UTC) #4
*** Submitted:

Removed no longer needed workaround.

The file app/models/charm.js was added explicitly 
in bin/merge-files. Apparently this workaround
is no longer required: the file is correctly
collected by lib/merge-files.js:readdir.

R=gary.poster, teknico
CC=
https://codereview.appspot.com/7033053
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b