Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(326)

Issue 7031050: code review 7031050: net/http: Sync TimeoutHandler godoc with code. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by mdempsky
Modified:
12 years, 6 months ago
Reviewers:
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

net/http: Sync TimeoutHandler godoc with code. TimeoutHandler was changed from "ns int64" to "dt time.Duration" on Nov 30, 2011, but the godoc still refers to "ns".

Patch Set 1 #

Patch Set 2 : diff -r 6e941dd4ded3 https://code.google.com/p/go #

Patch Set 3 : diff -r 6e941dd4ded3 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/pkg/net/http/server.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
mdempsky
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
12 years, 6 months ago (2013-01-03 00:27:33 UTC) #1
bradfitz
LGTM But I can't submit now. Others can. On Jan 3, 2013 8:55 AM, <mdempsky@google.com> ...
12 years, 6 months ago (2013-01-03 17:08:35 UTC) #2
iant
12 years, 6 months ago (2013-01-03 18:06:09 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=d0d76b7fb219 ***

net/http: Sync TimeoutHandler godoc with code.

TimeoutHandler was changed from "ns int64" to "dt time.Duration" on
Nov 30, 2011, but the godoc still refers to "ns".

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/7031050

Committer: Ian Lance Taylor <iant@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b