Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(27)

Issue 7030063: Get Launchpad team information from SSO

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by abentley-home
Modified:
11 years, 3 months ago
Reviewers:
hazmat, mp+141942
Visibility:
Public.

Description

Get Launchpad team information from SSO teams.py is copied verbatim from django-openid-auth. django-openid-auth cannot be added as a requirement, because that would introduce a dependency on django. I've emailed Anthony Lenton to see if we can come up with a better long-term solution. In order to use the teams extension, UbuntuSSOConsumer is introduced. This also allows us to specify the identifier directly, simplifying our login URLs. Since the teams extension requires us to specify which teams we care about, I've specified 'charmers'. Since AuthTktAuthenticationPolicy wants its callback to return a list of principals, and since principals can be users or groups, I've tweaked the naming of UserMgr.auth_groupfinder. It prefixes user ids with 'user ' and Launchpad team ids with 'group '. As a drive-by, dev-ingest is updated to use the correct python location. https://code.launchpad.net/~abentley/charmworld/sso/+merge/141942 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+492 lines, -32 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M charmworld/__init__.py View 3 chunks +3 lines, -3 lines 0 comments Download
M charmworld/lib/auth.py View 2 chunks +1 line, -5 lines 0 comments Download
M charmworld/models.py View 3 chunks +16 lines, -21 lines 0 comments Download
A charmworld/teams.py View 1 chunk +411 lines, -0 lines 1 comment Download
M charmworld/test_models.py View 2 chunks +15 lines, -2 lines 0 comments Download
M charmworld/testing/factory.py View 1 chunk +1 line, -0 lines 0 comments Download
A charmworld/ubuntusso.py View 1 chunk +42 lines, -0 lines 1 comment Download
M scripts/dev-ingest View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
abentley-home
Please take a look.
11 years, 3 months ago (2013-01-04 15:45:40 UTC) #1
hazmat
11 years, 3 months ago (2013-01-04 16:18:59 UTC) #2
looks good, land with changes.

https://codereview.appspot.com/7030063/diff/1/charmworld/teams.py
File charmworld/teams.py (right):

https://codereview.appspot.com/7030063/diff/1/charmworld/teams.py#newcode1
charmworld/teams.py:1: # Launchpad OpenID Teams Extension support for
python-openid
can you note as a prefix header the original source to this file (and its copy
date), i assume we're not pulling tests due to django deps?

https://codereview.appspot.com/7030063/diff/1/charmworld/ubuntusso.py
File charmworld/ubuntusso.py (right):

https://codereview.appspot.com/7030063/diff/1/charmworld/ubuntusso.py#newcode24
charmworld/ubuntusso.py:24: name='ubuntu_sso'):
the name parameter doesn't seem to be configurable as the lookup key is
hardcoded at usage, ie. should probably just be a constant and referenced as
such for the def/registration here and consumers elsewhere.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b